Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #2831, added some presence settings & migrated to presence helpers #2837

Merged
merged 6 commits into from
Jan 20, 2021
Merged

Fix issue #2831, added some presence settings & migrated to presence helpers #2837

merged 6 commits into from
Jan 20, 2021

Conversation

alexbcberio
Copy link
Contributor

  • Fix issue [Bug | Presence] Jellyfin #2831 where getting presence metadata would fail if the service was installed under a subpath such as https://domain.tld/jellyfin.
  • Used presence helpers for console logging, and getting timestamps from media elements.
  • Added some presence settings:
    • Show media timestamps (boolean): show or hide timestamps when playing back media
    • Show timestamps (boolean): show or hide timestamps for other cases

Proof screenshots:

presence settings
show timestamps on true
show timestamps on false
show media timestamps on true
show media timestamps on false
media paused

@mergify mergify bot merged commit 1f4477a into PreMiD:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bas950 Bas950 Bas950 approved these changes

@rxri rxri rxri approved these changes

@Timeraa Timeraa Awaiting requested review from Timeraa

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbcberio @rxri @Bas950