Added xero.gg support. #2451
Merged
Added xero.gg support. #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxri
suggested changes
Nov 10, 2020
rxri
previously approved these changes
Nov 10, 2020
rxri
suggested changes
Nov 11, 2020
|
I hope it's okay now.. |
Bas950
requested changes
Nov 11, 2020
websites/X/Xero.gg/presence.ts
Outdated
Comment on lines
53
to
63
| const claninfo = [ | ||
| document.querySelector( | ||
| "#player-profile-header-heading > div.medium.normal-color-name" | ||
| ).textContent, | ||
| document.querySelector( | ||
| "#clan-data-container > div > div.col-sm-3 > div > div.xero-pane-body > ul > li" | ||
| ).lastChild.textContent, | ||
| document.querySelector( | ||
| "#clan-data-container > div > div.col-sm-9 > div:nth-child(2) > div > div > a > div.media-body.ml-2 > div.bold" | ||
| ).textContent | ||
| ]; |
There was a problem hiding this comment.
thats an array, thats now how you merge consts
const var1 = obj,
var2 = obj2;
|
Okay I hope I finally understood it now. |
rxri
approved these changes
Nov 11, 2020
|
just to be sure please upload new proof of it working |
|
Ah sure, 1 sec |
|
@Bas950 I replaced the Showcase Link with a new video (You can also see the current date and time of windows) |
Bas950
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showcase: Showcase
Website: xero.gg
What it is: xero.gg is a player and clan database for the private server called "S4 Xero" of the base game "S4 League".
What the presence does: The presence mainly shows what profile or clan you are currently looking at or what news you are currently reading. More features included and might follow.
Screenshots of the presence:
