Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make variants.variant_seed non-null #11178

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Make variants.variant_seed non-null #11178

merged 1 commit into from
Jan 17, 2025

Conversation

nwalters512
Copy link
Contributor

Closes #11091.

@github-actions GitHub Actions
Copy link
Contributor

All images

Image Platform Old Size New Size Change
prairielearn/executor:f6a2116484285911b1ce4655b5ba8460cc183f59 null 1211.48 MB 1211.47 MB -0.00%
prairielearn/prairielearn:f6a2116484285911b1ce4655b5ba8460cc183f59 linux/amd64 1211.46 MB 1211.47 MB 0.00%

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.09%. Comparing base (86f9bde) to head (f6a2116).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11178      +/-   ##
==========================================
+ Coverage   72.07%   72.09%   +0.01%     
==========================================
  Files         590      590              
  Lines       95351    95351              
  Branches     7694     7691       -3     
==========================================
+ Hits        68727    68740      +13     
+ Misses      26133    26121      -12     
+ Partials      491      490       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwalters512 nwalters512 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 6d04f25 Jan 17, 2025
9 checks passed
@nwalters512 nwalters512 deleted the variant-seed-nonnull branch January 17, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mylesw27 mylesw27 mylesw27 approved these changes

@reteps reteps Awaiting requested review from reteps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make variant_seed field non nullable
2 participants
@nwalters512 @mylesw27