Update docker files to allow specifying pwsh and from image version #6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
May 7, 2018
| @@ -46,7 +49,9 @@ RUN curl https://packages.microsoft.com/config/ubuntu/16.04/prod.list | tee /etc | |||
| # Install powershell from Microsoft Repo | |||
| RUN apt-get update \ | |||
| && apt-get install -y --no-install-recommends \ | |||
| powershell | |||
| powershell=${POWERSHELL_VERSION}-1.ubuntu.16.04 \ | |||
There was a problem hiding this comment.
can you make the version postfix a variable.
| powershell | ||
| powershell=${POWERSHELL_VERSION}-1.ubuntu.16.04 \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lis |
TravisEz13
force-pushed
the
allow_specifying_pwsh_version
branch
from
8586510 to
8f45945
Compare
adityapatwardhan
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update docker files to allow specifying pwsh and from image version
- Also updated to install security updates when building images
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests