Updates to fedora27 and kalilinux dockerfiles #6819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
reviewed
May 3, 2018
| @@ -26,6 +26,7 @@ LABEL maintainer="PowerShell Team <powershellteam@hotmail.com>" \ | |||
| RUN dnf install -y \ | |||
| curl \ | |||
| glibc-locale-source \ | |||
There was a problem hiding this comment.
We should consider adding the folloiwng to the image
dnf upgrade-minimal -y --security
This will apply any security updates to the image.
There was a problem hiding this comment.
Might be a good idea. I've added this change and rerun package tests - build time does not seem to be impacted much.
11 tasks
TravisEz13
requested changes
May 4, 2018
docker/release/fedora27/Dockerfile
Outdated
| @@ -22,6 +22,9 @@ LABEL maintainer="PowerShell Team <powershellteam@hotmail.com>" \ | |||
|
|
|||
| # TODO: addd LABEL org.label-schema.vcs-ref=${VCS_REF} | |||
|
|
|||
| # Apply any security updates to the image | |||
| RUN dnf upgrade-minimal -y --security | |||
There was a problem hiding this comment.
you should run dnf clean all before you write the layer (the end of the run statement)
TravisEz13
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 issues:
fedora27dockerfiles were missingcompat-openssl10prerequisite that on Linux-based Docker hosts produced errorNo usable version of the libssl was foundduringRestore-PSPester.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests