Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 #24300

Merged
merged 32 commits into from
Sep 23, 2024
Merged

Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 #24300

merged 32 commits into from
Sep 23, 2024

Conversation

alerickson
Copy link
Member

PR Summary

Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 and add some tests for Publish-PSResource and Compress-PSResource

PR Context

PR Checklist

@kilasuit
Copy link
Collaborator

kilasuit commented Sep 20, 2024 •
edited
Loading

Only minor comment - do we need these tests in this repo (do they bring any real benefit to building PowerShell) as opposed to just being part of the build and release process for PSResourceGet?

By this I mean could we remove the Microsoft.PowerShell.PSResourceGet.Tests.ps1 file completely from this repo (whether now or in future)

@adityapatwardhan
Copy link
Member

@kilasuit Thanks for the feedback. We have them as acceptance tests and hence they are very comprehensive. It is to test whether the newer version of PSResourceGet works with the latest PS bits. PSResourceGet tests on stable versions of PowerShell 7 and Windows PowerShell in its own repository. It does not test on PS Preview versions.

Also, when we update .NET on PS Previews, we want to ensure PSResourceGet cmdlets are still working fine.

@kilasuit
Copy link
Collaborator

@kilasuit Thanks for the feedback. We have them as acceptance tests and hence they are very comprehensive. It is to test whether the newer version of PSResourceGet works with the latest PS bits. PSResourceGet tests on stable versions of PowerShell 7 and Windows PowerShell in its own repository. It does not test on PS Preview versions.

Also, when we update .NET on PS Previews, we want to ensure PSResourceGet cmdlets are still working fine.

Thanks @adityapatwardhan, this makes sense and I only really asked to confirm my understanding of the overall testing matrix.

@alerickson alerickson changed the title WIP: Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 Sep 23, 2024
@adityapatwardhan adityapatwardhan merged commit 669d9e3 into PowerShell:master Sep 23, 2024
41 checks passed
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 23, 2024 •
edited by unfurl-links bot
Loading

📣 Hey @alerickson, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Sep 23, 2024
@alerickson @adityapatwardhan
Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 (Powe…
58e59cd 
…rShell#24300)
@adityapatwardhan adityapatwardhan mentioned this pull request Sep 23, 2024
Merged
adityapatwardhan added a commit that referenced this pull request Sep 24, 2024
@adityapatwardhan
Update Microsoft.PowerShell.PSResourceGet to 1.1.0-preview2 (#24300…
5733a9c 
…) (#24337)
@jshigetomi jshigetomi added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 12, 2024
@jshigetomi jshigetomi mentioned this pull request Jan 17, 2025
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga anmenaga is a code owner

Assignees
No one assigned
Labels
BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alerickson @kilasuit @adityapatwardhan @jshigetomi