Remember installation options and used them to initialize options for the next installation #20420

reduckted · 2023-10-02T07:10:28Z

PR Summary

When the Windows installer runs, it will save the selected options ("Add to Path Environment Variable", "Enable PowerShell remoting", etc.) to the registry. When the installer for the next version runs, the state of the options is loaded from the registry and used to initialize the installer's options.

PR Context

There has been a lot of issues logged about this:

In summary, when the installer runs, it does not know about any of the options that were selected on the previous install. If you run the installer manually, you need to re-select the options that you selected during the previous install. If the installer is run automatically (such as via Windows Update), then the default options are used, potentially resulting in some of the options that you previously selected from being turned off (for example, context menus are removed).

PR Checklist

To implement this, I've used the "Remember Property" pattern with a slight twist. The pattern described in that blog post does not account for how a checkbox sets its initial state. If a property value is not blank, then the checkbox will be initially checked, regardless of what the CheckBoxValue is. So, for example, if ADD_PATH is set to 0, the checkbox will be checked. If ADD_PATH is set to 1, the checkbox will be checked. If ADD_PATH does not exist, then the checkbox will be unchecked. I won't go into the full details of how this is handled, because there's a detailed comment that explains it all.

The installer settings are saved to HKLM\Software\Microsoft\PowerShellCore\InstallerProperties. Preview versions are saved to a different key, but these settings will be shared between major versions. For example, PowerShell v8 will use the settings saved by PowerShell v7. I don't think that will be a problem, but just wanted to point it out. 😄 That registry key also remains behind after uninstalling PowerShell, so if you have to uninstall and reinstall for whatever reason, the settings that you originally used will be the defaults when you reinstall.

Technically the way that the property values are now handled could be considered a breaking change for some of those properties. Previously, some properties were compared to 1 and other properties were just checked if they had a value.

For example, previously if you ran the installer like this:

msiexec.exe /i PowerShell.msi ADD_EXPLORER_CONTEXT_MENU_OPENPOWERSHELL=YesAddTheContextMenu

Then the context menu would be created. Now if you do that, the installer will not create the context menu. The context menu is only created if the property value is 1.

Not all properties were treated this way. For example, ADD_PATH had to have a value of 1, as did a couple of the other properties.

It's worth noting that the documentation for running the installer from the command line uses an example where it sets all property values to 1. If you followed that example, then you won't see any change in behavior.

… the next installation. Fixes PowerShell#16886

reduckted · 2023-10-02T10:48:37Z

Oops, I didn't realize there were automated tests for the installer. I'll get those fixed up as soon as I can.

reduckted · 2023-10-05T08:40:47Z

I'm pretty sure those "macos" build failures are unrelated to the changes from this PR.

TravisEz13 · 2023-10-27T20:07:40Z

@heaths Can you help review this?

TravisEz13 · 2023-10-27T21:24:43Z

I believe this is a bucket 3 breaking change that doesn't require committee approval. The behaviors that are broken were not intended behavior as you could see by passing no or false as variable value.

@reduckted Can we abort the install if one of the variable values is invalid with a specific exit code?

heaths · 2023-10-28T00:30:14Z

assets/wix/Product.wxs

@@ -292,6 +465,17 @@
                </RegistryKey>
              </RegistryKey>
            </Component>
+            <Component Id="SaveInstallerProperties" Permanent="yes">


I don't advise permanent components. This means users will have a hard time changing in the future, and leaves cruft behind in the registration. Perhaps it's better to change the MajorUpgrade element to use afterInstallExecute. Not only is it faster to upgrade, it will prefer existing components until the product is removed (not via upgrade).

@TravisEz13 this would need to be well-tested, though. The current behavior removes the old product first then installs the new product. This is inefficient, but safe for refactorings that might otherwise change component GUIDs. Doubt that's happened in a very long time, though - not since I did a bunch of preview vs. stable refactorings a long time ago. May not be worth retaining that behavior anymore.

heaths · 2023-10-28T00:38:29Z

assets/wix/Product.wxs

+    <SetProperty Id="ADD_PATH" Action="AddToPath_DeleteIfOff" After="AddToPath_SetDefault" Value="{}" Sequence="first">
+      ADD_PATH&lt;&gt;1
+    </SetProperty>
+    <SetProperty Id="ADD_PATH" Action="AddToPath_SetToOffIfMissing" Before="InstallInitialize" Value="0" Sequence="execute">
+      not ADD_PATH
+    </SetProperty>


This seems unnecessarily complicated. If the property is not defined to any value, it's already unset by Windows Installer's definition, thus not needing all the explicit ...=1 conditions below.

It's also fine to just bind the actual property to the RegistrySearch. See https://robmensching.com/blog/posts/2010/5/2/the-wix-toolsets-remember-property-pattern/.

The reason for this complexity is explained in the comments above. What that "Remember Property" pattern doesn't handle is allowing the option to be changed via a checkbox in the UI. If a property has a value, the checkbox that uses that property will be initially checked. It doesn't matter whether the property's value is 0 or 1 or something else; if the property exists, the checkbox is checked. So if the option was disabled, we would remember the property value as 0. On the next install, that property would be initialized to the value of 0, but because the property exists, the checkbox would initially be checked.

I'm definitely not a WiX expert, so if there's a simpler way to do this, I'd love to know.

If 0 is checking the check box, it could be that the Integer attribute needs to be set on it. It should be able to bind directly if treated as an integer instead of the default string (which is set if it has any value since 0 is actually "0" in that case).

😞 Unfortunately that didn't help. I tried it out on the checkbox for ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL like so:

<Control Id="ContextMenuRunPowerShell" Type="CheckBox" X="20" Y="160" Width="290" Height="17" Property="ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL" Integer="yes" CheckBoxValue="1" Text="Add '$(var.PowerShellFileContextSubMenuDialogText)' context menu for PowerShell files"/>

And I reduced the property initialization back to just getting the previous value and restoring the previous value:

<Property Id="PREVIOUS_ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL"> <RegistrySearch Id="GetSavedAddFileContextMenuRunPowerShell" Root="HKLM" Key="$(var.InstallerPropertiesKey)" Name="AddFileContextMenuRunPowerShell" Type="raw" /> </Property> <SetProperty Id="ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL" Action="AddFileContextMenuRunPowerShell_SetFromSaved" After="AppSearch" Value="[PREVIOUS_ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL]" Sequence="first"> PREVIOUS_ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL </SetProperty>

Running the installer like this...

msiexec /i PowerShell-7.4.2-test-win-x64.msi ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL=0

... causes the checkbox to be initially checked. So does:

Running with ADD_FILE_CONTEXT_MENU_RUNPOWERSHELL=1.

Having the registry value AddFileContextMenuRunPowerShell equal to 0.

Having the registry value AddFileContextMenuRunPowerShell equal to 1.

That's unfortunate. I'm reaching out to a colleague who has done more Windows Installer UI, but it could be that the extra CAs are needed. It'd be nice to avoid, though. I'll flag this for follow up.

MSI, both in general and specifically for check boxes, uses the logic that a null string is false and anything else is true.

The selected state of the box sets the property either to the value specified in the Value column of the CheckBox table or to the initial value of the property specified in the Property table.

So this behavior seems consistent.

I wonder how the Integer flag is actually supposed to work then.

I'll re-review this, but might play around a bit with a scratch package. The number of CAs necessary to make this work seem like overkill, but maybe not. What you have certainly works.

pull-request-quantifier-deprecated · 2023-10-31T11:08:02Z

This PR has 205 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +192 -13
Percentile : 60.5%

Total files changed: 2

Change summary by file extension:
.wxs : +174 -13
.ps1 : +18 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

heaths · 2024-04-17T16:52:06Z

probably also related to the installation options: the installer wipes and replaces the PS7 shortcut in the start menu even if nothing was changed in the executable path name or arguments, but when it replaces the shortcut it does not re-create the advanced properties that the old shortcut had been assigned by the system administrator. (run as administrator, file classification infrastructure data stream)

#21466

@R-Adrian in short, that's how Windows Installer works but there's an easy (and typical) workaround. See #21466 (comment).

floh96 · 2024-04-18T16:28:25Z

@StevenBucher98 @heaths approved the pr. Can you help to speed up the review from the powershell team?

SteveL-MSFT

Based on the discussion and the resulting changes, LGTM

TravisEz13 · 2024-05-06T18:14:09Z

/azp run PowerShell-CI-macos

azure-pipelines · 2024-05-06T18:14:20Z

Azure Pipelines successfully started running 1 pipeline(s).

* Bump xunit from 2.6.3 to 2.6.4 (PowerShell#20967) Bumps [xunit](https://github.com/xunit/xunit) from 2.6.3 to 2.6.4. - [Commits](xunit/xunit@2.6.3...2.6.4) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump xunit.runner.visualstudio from 2.5.5 to 2.5.6 (PowerShell#20966) Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.5 to 2.5.6. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.5.5...2.5.6) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Import-LocalizedData implicit Localization fallback (PowerShell#19896) * Adds culture fallback to Import-LocalizedData * Only add fallback if current culture is not en-US * Pester 4 compatibility * Missing param block in It * Missed param block for It * Skip UICulture name test for Linux and Mac * Removed test fragment * Fix typo in remotingexceptions.cs (PowerShell#21015) formating -> formatting * Fix failures in GitHub action `markdown-link-check` (PowerShell#20996) * Bump xunit from 2.6.4 to 2.6.5 (PowerShell#21008) * Include information about upgrading in README (PowerShell#20993) * Update the cgmanifest (PowerShell#20955) * Add `Aliases` to the properties shown up when formatting the help content of the parameter returned by `Get-Help` (PowerShell#20994) * Bump JsonSchema.Net from 5.4.2 to 5.5.0 (PowerShell#21027) * Fix regression -Tail 0 -Wait (PowerShell#20734) * Update README.md and metadata.json for v7.2.18 and v7.4.1 releases (PowerShell#21044) * Update changelog for v7.2 and v7.3 (PowerShell#21052) * Bump xunit from 2.6.5 to 2.6.6 (PowerShell#21071) * Bump StyleCop.Analyzers from 1.2.0-beta.507 to 1.2.0-beta.556 (PowerShell#20953) * Update to the latest NOTICES file (PowerShell#20905) * Update the cgmanifest (PowerShell#21047) * Fix completion crash for the SCCM provider (PowerShell#20915) * Bump .NET SDK to 8.0.101 (PowerShell#21084) * Add `WinGetCommandNotFound` and `CompletionPredictor` modules to track usage (PowerShell#21040) * Merged PR 29314: Update ChangeLog for v7.5.0-preview.1 Update ChangeLog for v7.5.0-preview.1 * Update `README.md` and `metadata.json` for v7.5.0-preview.1 release (PowerShell#21094) * Fix Get-Error serialization of array values (PowerShell#21085) Ensure Get-Error does not hang when attempting to serialize an exception that contains a property whose type is an array of System.Type instances. Also ensures that primitive types like System.Int32, System.Boolean as well as System.String is formatted as a string rather than an object with properties. * Validate the value for `using namespace` during semantic checks to prevent declaring invalid namespaces (PowerShell#21162) * Fix `using assembly` to use `Path.Combine` when constructing assembly paths (PowerShell#21169) * Add `DirectoryInfo` to the `OutputType` for `New-Item` (PowerShell#21126) * Bump JsonSchema.Net to v5.5.1 (PowerShell#21120) * Update changelog for v7.4.1 (PowerShell#21098) * Update WG members (PowerShell#21091) * Update the cgmanifest (PowerShell#21093) * Fix incorrect examples in XML docs in `PowerShell.cs` (PowerShell#21173) * Generate MSI for `win-arm64` installer (PowerShell#20516) * Rewrite the mac syslog tests to make them less flaky (PowerShell#21174) * Update versions of PSResourceGet (PowerShell#21190) * Add tilde expansion for windows native executables (PowerShell#20402) * Bump XunitXml.TestLogger from 3.1.17 to 3.1.20 (PowerShell#21207) * Remove `PSScheduledJob` module source code (PowerShell#21189) * Update to the latest NOTICES file (PowerShell#21177) * Update the cgmanifest (PowerShell#21178) * Fix a typo in `CoreAdapter.cs` (PowerShell#21179) * ConvertFrom-Json: Add -DateKind parameter (PowerShell#20925) Adds the -DateKind parameter to the ConvertFrom-Json that allows the caller to control how DateTime strings are converted into an object. The default behaviour is to create a DateTime value with the Kind being Unspecified if no TZ is set, Utc if the TZ Z is set, Local (after conversion) if an explicit TZ is set. This adds a Utc, Local to explicitly set the Kind as desired as well as a Offset and String value to create a DateTimeOffset or keep as a string. * Bump Microsoft.NET.Test.Sdk from 17.8.0 to 17.9.0 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.8.0 to 17.9.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.8.0...v17.9.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update dependabot.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Create codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Bump the nuget group across 1 directories with 1 update Bumps the nuget group with 1 update in the /test/tools/TestAlc/nested directory: [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json). Updates `Newtonsoft.Json` from 10.0.1 to 13.0.1 - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@10.0.1...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Bump PowerShellGet from 2.2.5 to 2.2.5.1 in /src/Modules Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.2.5 to 2.2.5.1. - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/master/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) --- updated-dependencies: - dependency-name: PowerShellGet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump to .NET 9 Preview 1 (PowerShell#21229) * Update the cgmanifest (PowerShell#21237) * Update to the latest NOTICES file (PowerShell#21236) * Update experimental-feature json files (PowerShell#21213) * Remove `surrogateFile` setting of APIScan (PowerShell#21238) * Add dotenv install as latest version does not work with current Ruby version (PowerShell#21239) * Bump xunit from 2.6.6 to 2.7.0 Bumps [xunit](https://github.com/xunit/xunit) from 2.6.6 to 2.7.0. - [Commits](xunit/xunit@2.6.6...2.7.0) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump xunit.runner.visualstudio from 2.5.6 to 2.5.7 Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.6 to 2.5.7. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.5.6...2.5.7) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Add dotnet-runtime-9.0 as a dependency for the Mariner package (PowerShell#21259) * Adding WG membership template (PowerShell#21153) * Adding WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Update .github/ISSUE_TEMPLATE/WG_member_request.yaml Co-authored-by: Steve Lee <slee@microsoft.com> * Update .github/ISSUE_TEMPLATE/WG_member_request.yaml Co-authored-by: Steve Lee <slee@microsoft.com> --------- Co-authored-by: Jason.Helmick <jahelmic@microsoft.com> Co-authored-by: Steve Lee <slee@microsoft.com> * Update `metadata.json` and `README.md` (PowerShell#21264) * Skip test on Windows Server 2012 R2 for `no-nl` (PowerShell#21265) * Fix a regression in `Format-Table` when header label is empty (PowerShell#21156) * Revert "Adjust PUT method behavior to POST one for default content type in WebCmdlets" (PowerShell#21049) * Fix the regression when doing type inference for `$_` (PowerShell#21223) * ConvertTo-Json: Serialize `BigInteger` as a number (PowerShell#21000) * Remove `JetBrains.Annotations` attributes (PowerShell#21246) * Suppress MacOS package manager output (PowerShell#21244) * Enable CA1868: Unnecessary call to 'Contains' for sets (PowerShell#21165) https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1868 * Bump Microsoft.CodeAnalysis.CSharp from 4.8.0 to 4.9.2 Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.8.0 to 4.9.2. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Microsoft.CodeAnalysis.Analyzers (PowerShell#21297) * Bump Microsoft.CodeAnalysis.CSharp from 4.9.0-3.final to 4.9.2 (PowerShell#21298) * Fix error formatting for pipeline enumeration exceptions (PowerShell#20211) * Fall back to type inference when hashtable key value cannot be retrieved from safe expression (PowerShell#21184) * Get-Process: Remove admin requirement for `-IncludeUserName` (PowerShell#21302) * Bump Microsoft.CodeAnalysis.Analyzers (PowerShell#21305) * Fix a typo in `releaseTools.psm1` (PowerShell#21306) * Fix PowerShell class to support deriving from an abstract class with abstract properties (PowerShell#21331) * Handle the case that `Runspace.DefaultRunspace is null` when logging for WDAC Audit (PowerShell#21344) * Make sure both stdout and stderr can be redirected from a native executable (PowerShell#20997) * Fix typo in ast.cs (PowerShell#21350) statment -> statement * Make sure the assembly/library resolvers are registered at early stage (PowerShell#21361) * Revert the PR PowerShell#17856 (Do not preserve temporary results when no need to do so) (PowerShell#21368) * Add file description to `pwsh.exe` (PowerShell#21352) * PowerShell co-ordinated build OneBranch pipeline (PowerShell#21364) * Fix argument passing in `GlobalToolShim` (PowerShell#21333) * Fix build failure due to missing reference in `GlobalToolShim.cs` (PowerShell#21388) * Fix typo in a test (PowerShell#21337) connectiong -> connecting * Fix `Test-Path -IsValid` to check for invalid path and filename characters (PowerShell#21358) * Fix typo in SessionStateCmdletAPIs.cs (PowerShell#21413) hte -> the * Update `PSReadLine` to `v2.3.5` for the next `v7.4.x` servicing release (PowerShell#21414) * Multiple fixes in official build pipeline (PowerShell#21408) * Add back two transitive dependency packages (PowerShell#21415) * Verify environment variable for OneBranch before we try to copy (PowerShell#21441) * Update PSResourceGet version from 1.0.2 to 1.0.4.1 (PowerShell#21439) * fix package build to not check some files for a signature. (PowerShell#21458) * Update `metadata.json` and `README.md` (PowerShell#21454) * Fix grammar in FAQ.md (PowerShell#21468) Fix grammar in docs FAQ * Update CHANGELOG for v7.2.19, v7.3.12 and v7.4.2 (PowerShell#21462) * Fix the error when using `Start-Process -Credential` without the admin privilege (PowerShell#21393) * Add `RecommendedAction` to `ConciseView` of the error reporting (PowerShell#20826) * Update Engine & Interactive-UX Working Group Member lists (PowerShell#20991) * Bump `Microsoft.CodeAnalysis.Analyzers` (PowerShell#21449) * Don't complete parameter name and class member declarations (PowerShell#21182) * Update the doc about how to build PowerShell (PowerShell#21334) * [StepSecurity] Apply security best practices (PowerShell#21480) * [StepSecurity] Apply security best practices Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> * Update dependabot.yml * Delete tools/releaseBuild/Images/microsoft_powershell_centos7 directory * Delete tools/releaseBuild/Images/microsoft_powershell_ubuntu16.04 directory * Delete tools/releaseBuild/Images/microsoft_powershell_ubuntu18.04 directory * Delete tools/releaseBuild/Images/microsoft_powershell_windowsservercore/Dockerfile --------- Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> * Bump ossf/scorecard-action from 2.0.6 to 2.3.1 (PowerShell#21485) * Bump ossf/scorecard-action from 2.0.6 to 2.3.1 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.6 to 2.3.1. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@99c5375...0864cf1) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update windows.yml * Update linux.yml * Update windows.yml * Update mac.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> * Bump actions/upload-artifact from 3.1.3 to 4.3.2 (PowerShell#21501) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.3.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@a8a3f3a...1746f4a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.25.0 to 3.25.1 (PowerShell#21498) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.25.0 to 3.25.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2.25.0...c7f9125) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.6.0 to 4.1.2 (PowerShell#21482) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.6.0...9bb5618) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/dependency-review-action from 2.5.1 to 4.2.5 (PowerShell#21484) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 2.5.1 to 4.2.5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@0efb1d1...5bbc3ba) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add a PAT for fetching PMC cli (PowerShell#21503) * Use new pat * remove trailing whitespaces * Fix `[semver]` type to pass semver.org tests (PowerShell#21401) * Fix `[semver]` type to pass semver.org tests * fix test to split per OS specific newline * replace all regex with semver.org ones adding new one for build label, update tests --------- Co-authored-by: Steve Lee (POWERSHELL HE/HIM) (from Dev Box) <slee@ntdev.microsoft.com> * Separate DSC configuration parser check for ARM processor (PowerShell#21395) * Official PowerShell Package pipeline (PowerShell#21504) * Revert to version available on `Nuget` for `Microsoft.CodeAnalysis.Analyzers` (PowerShell#21515) * Use correct signing certificates for RPM and DEBs (PowerShell#21522) * Add branch counter variables for daily package builds (PowerShell#21523) * Expand `~` to `$home` on Windows with tab completion (PowerShell#21529) * Bump github/codeql-action from 3.25.1 to 3.25.3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.1 to 3.25.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@c7f9125...d39d31e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/checkout from 4.1.2 to 4.1.4 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@9bb5618...0ad4b8f) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/upload-artifact from 4.3.2 to 4.3.3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@1746f4a...6546280) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump super-linter/super-linter from 5.7.2 to 6.4.1 Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 5.7.2 to 6.4.1. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](super-linter/super-linter@a8150b4...4758be6) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Delete .github/workflows/codeql-analysis.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Update codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Update codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Delete .github/workflows/codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Bump actions/dependency-review-action from 4.2.5 to 4.3.2 Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.2.5 to 4.3.2. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@5bbc3ba...0c155c5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update wix package install (PowerShell#21537) * Create the Windows.x64 global tool with shim for signing (PowerShell#21559) * Fix generating `OutputType` when running in Constrained Language Mode (PowerShell#21605) * Use PSScriptRoot to find path to Wix module (PowerShell#21611) * Bump actions/checkout from 4.1.4 to 4.1.5 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@0ad4b8f...44c2b7a) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Remember installation options and used them to initialize options for the next installation (PowerShell#20420) * Bump github/codeql-action from 3.25.3 to 3.25.4 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.3 to 3.25.4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d39d31e...ccf74c9) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump to .NET 9 preview 3 (PowerShell#21782) * Bump ossf/scorecard-action from 2.3.1 to 2.3.3 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.1 to 2.3.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@0864cf1...dc50aa9) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Use feed with Microsoft Wix toolset (PowerShell#21651) * Create codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Bump super-linter/super-linter from 6.4.1 to 6.5.0 Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 6.4.1 to 6.5.0. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](super-linter/super-linter@4758be6...56576d4) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Dent <134605137+chrisdent-de@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: James Truher [MSFT] <jimtru@microsoft.com> Co-authored-by: Steven Bucher <stevenbucher8@gmail.com> Co-authored-by: PowerShell Team Bot <69177312+pwshBot@users.noreply.github.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com> Co-authored-by: CarloToso <105941898+CarloToso@users.noreply.github.com> Co-authored-by: MartinGC94 <42123497+MartinGC94@users.noreply.github.com> Co-authored-by: Jordan Borean <jborean93@gmail.com> Co-authored-by: Greg Dennis <gregsdennis@yahoo.com> Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com> Co-authored-by: Anam Navied <anam.naviyou@gmail.com> Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com> Co-authored-by: Dom Slee <domslee1@gmail.com> Co-authored-by: Steve Lee <slee@microsoft.com> Co-authored-by: Aditya Patwardhan <adityap@microsoft.com> Co-authored-by: Jason Helmick <jason.helmick@microsoft.com> Co-authored-by: Jason.Helmick <jahelmic@microsoft.com> Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Co-authored-by: Friedrich von Never <friedrich@fornever.me> Co-authored-by: guangwu <guoguangwu@magic-shield.com> Co-authored-by: Roshan Ganesh <73138775+CodingGod987@users.noreply.github.com> Co-authored-by: Justin Grote <JustinGrote@users.noreply.github.com> Co-authored-by: Ryan Yates <ryan.yates@kilasuit.org> Co-authored-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Steve Lee (POWERSHELL HE/HIM) (from Dev Box) <slee@ntdev.microsoft.com> Co-authored-by: David Kontyko <33853225+dkontyko@users.noreply.github.com> Co-authored-by: Tess Gauthier <tgauth@bu.edu> Co-authored-by: Dave <reduckted@outlook.com>

TravisEz13 · 2024-08-13T19:56:27Z

This feature didn't exist in 7.2, so no backport needed to that branch.

… the next installation (PowerShell#20420)

… the next installation (#20420) (#24143)

… the next installation (PowerShell#20420)

Remember installation options and used them to initialize options for…

2669306

… the next installation. Fixes PowerShell#16886

pull-request-quantifier-deprecated bot added the Medium label Oct 2, 2023

reduckted changed the title ~~Remember installation options and used them to initialize options for the next installation~~ WIP: Remember installation options and used them to initialize options for the next installation Oct 2, 2023

reduckted marked this pull request as draft October 2, 2023 10:47

pull-request-quantifier-deprecated bot added Large and removed Medium labels Oct 3, 2023

Reset saved installer properties before each installer test.

52b6676

reduckted force-pushed the feature/16886-remember-installer-options branch from c41e497 to 52b6676 Compare October 3, 2023 11:24

Fix installer tests to work on x86 runtime.

ca31809

reduckted changed the title ~~WIP: Remember installation options and used them to initialize options for the next installation~~ Remember installation options and used them to initialize options for the next installation Oct 4, 2023

reduckted marked this pull request as ready for review October 4, 2023 12:04

daxian-dbw requested a review from TravisEz13 October 5, 2023 16:19

daxian-dbw assigned TravisEz13 Oct 5, 2023

StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Oct 9, 2023

microsoft-github-policy-service bot added Review - Needed The PR is being reviewed labels Oct 17, 2023

microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Oct 27, 2023

TravisEz13 added Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log labels Oct 27, 2023

heaths reviewed Oct 28, 2023

View reviewed changes

Correct registry value names for saved context menu options.

da30b9e

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Nov 11, 2023

This was referenced Nov 23, 2023

Contextual menu disappears after PS auto upgrade #18479

Closed

Powershell Core Windows Exporer integration disappears after automatic Windows Update #17967

Closed

Feature Request: Add option "only show new options" to PowerShell installer #14883

Closed

heaths approved these changes Apr 16, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

SteveL-MSFT approved these changes Apr 22, 2024

View reviewed changes

kilasuit mentioned this pull request Apr 24, 2024

Silent Update removes context menu entry if previously added #16886

Closed

5 tasks

microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label May 6, 2024

TravisEz13 enabled auto-merge (squash) May 6, 2024 18:14

TravisEz13 merged commit 11a7448 into PowerShell:master May 7, 2024
38 checks passed

reduckted deleted the feature/16886-remember-installer-options branch May 7, 2024 22:00

R-Adrian mentioned this pull request May 16, 2024

GDPR consent problem: PowerShell 7.4.5 installer forcefully enables telemetry on upgrade even if previous version was installed with telemetry disabled #21467

Closed

5 tasks

SteveL-MSFT mentioned this pull request Jul 15, 2024

Failed to update powershell preview by winget because it told me need the old(now) version package(msi) to uninstall #24052

Closed

5 tasks

adityapatwardhan added Backport-7.2.x-Consider BackPort-7.4.x-Consider labels Jul 26, 2024

StevenBucher98 mentioned this pull request Aug 2, 2024

PowerShell 7 Upgrade MSI Setting Bug PowerShell/Announcements#67

Open

TravisEz13 added Backport-7.2.x-Approved BackPort-7.4.x-Approved and removed Backport-7.2.x-Consider BackPort-7.4.x-Consider labels Aug 13, 2024

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Aug 13, 2024

Remember installation options and used them to initialize options for…

d7e1fb7

… the next installation (PowerShell#20420)

daxian-dbw mentioned this pull request Aug 13, 2024

[release/v7.4.5] Remember installation options and used them to initialize options for the next installation #24143

Merged

daxian-dbw added a commit that referenced this pull request Aug 13, 2024

Remember installation options and used them to initialize options for…

d2a0a0a

… the next installation (#20420) (#24143)

daxian-dbw added BackPort-7.4.x-Done and removed BackPort-7.4.x-Approved labels Aug 13, 2024

chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024

Remember installation options and used them to initialize options for…

d50642d

… the next installation (PowerShell#20420)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remember installation options and used them to initialize options for the next installation #20420

Remember installation options and used them to initialize options for the next installation #20420

reduckted commented Oct 2, 2023 •

edited

Loading

reduckted commented Oct 2, 2023

reduckted commented Oct 5, 2023

TravisEz13 commented Oct 27, 2023

TravisEz13 commented Oct 27, 2023

heaths Oct 28, 2023

heaths Oct 28, 2023

reduckted Oct 29, 2023

heaths Oct 30, 2023

reduckted Oct 31, 2023

heaths Nov 2, 2023

barnson Nov 3, 2023

heaths Nov 3, 2023

pull-request-quantifier-deprecated bot commented Oct 31, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

This comment was marked as resolved.

heaths commented Apr 17, 2024

floh96 commented Apr 18, 2024

SteveL-MSFT left a comment

TravisEz13 commented May 6, 2024

azure-pipelines bot commented May 6, 2024

TravisEz13 commented Aug 13, 2024

Remember installation options and used them to initialize options for the next installation #20420

Remember installation options and used them to initialize options for the next installation #20420

Conversation

reduckted commented Oct 2, 2023 • edited Loading

PR Summary

PR Context

PR Checklist

reduckted commented Oct 2, 2023

reduckted commented Oct 5, 2023

TravisEz13 commented Oct 27, 2023

TravisEz13 commented Oct 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pull-request-quantifier-deprecated bot commented Oct 31, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

This comment was marked as resolved.

heaths commented Apr 17, 2024

floh96 commented Apr 18, 2024

SteveL-MSFT left a comment

Choose a reason for hiding this comment

TravisEz13 commented May 6, 2024

azure-pipelines bot commented May 6, 2024

TravisEz13 commented Aug 13, 2024

reduckted commented Oct 2, 2023 •

edited

Loading