Add tilde expansion for windows native executables #20402

domsleee · 2023-09-29T14:35:33Z

PR Summary

Attempted implementation for #20031.

Tilde expansion here is the same on windows as it is on unix, except that it also expands back slash.
i.e. ~, ~/...., and ~\.... are expanded.

PR Context

This comment: #20031 (comment)

My understanding is that tilde expansion was briefly introduced as part of a larger PR.
But that PR didn't handle double quotes properly, specifically "~" should not be expanded on windows, so it was removed.

There were also other issues with the PSNativePSPathResolution that lead to its removal, specifically around determining if the PSDrive argument was a file or not.

The failing example (from the previous PR) is:

$arg = 'temp:foo'; /bin/echo $arg | Should -be $arg

Expected: 'temp:foo' But was: '/var/folde...'

For tilde expansion, we don't need to consider this information. Tilde (with no quotes) should be always expanded.

We can use an experimental feature here if required, not sure if it is needed 👍

PR Checklist

domsleee · 2023-09-29T14:36:24Z

@microsoft-github-policy-service agree

domsleee · 2023-09-29T15:08:33Z

The place it is done for cmdlets like Get-ChildItem is here, and it supports ~, startsWith("~/") and startsWith("~\"):

PowerShell/src/System.Management.Automation/namespaces/LocationGlobber.cs

Lines 4542 to 4552 in dab6ca2

    
           if (path.IndexOf(StringLiterals.HomePath, StringComparison.Ordinal) == 0) 
        
           { 
        
               // Support the single "~" 
        
               if (path.Length == 1) 
        
                   result = true; 
        
               // Support "~/" or "~\" 
        
               else if ((path.Length > 1) && 
        
                       (path[1] == '\\' || 
        
                        path[1] == '/')) 
        
                   result = true; 
        
           }

SteveL-MSFT

Thanks for the contribution! Please wrap as an ExperimentalFeature as it also helps advertise the new capability and allow changes on feedback not to be a breaking change.

SteveL-MSFT · 2023-12-04T17:12:19Z

src/System.Management.Automation/engine/NativeCommandParameterBinder.cs

@@ -418,6 +418,27 @@ private void PossiblyGlobArg(string arg, CommandParameterInternal parameter, boo
            }
 #endif // UNIX

+#if !UNIX
+            if (ExperimentalFeature.IsEnabled(ExperimentalFeature.PSNativeWindowsTildeExpansion) && !usedQuotes)


This is where this feature gets a bit complicated and the original implementation was abandoned. Double quotes are expected to be expanded (like if your path has whitespace), but single quotes are treated as literal and never expanded. So this needs to be differentiated.

Would you expect tilde expansion if it was surrounded with double quotes? Currently pwsh on linux doesn't expand tilde for double quotes:

PowerShell/test/powershell/Language/Scripting/NativeExecution/NativeUnixGlobbing.Tests.ps1

Lines 130 to 133 in ac84c35

/bin/echo '~' | Should -BeExactly '~'

/bin/echo "~" | Should -BeExactly '~'

/bin/echo '~/foo' | Should -BeExactly '~/foo'

/bin/echo "~/foo" | Should -BeExactly '~/foo'

Also I checked bash, fish, zsh with /bin/echo "~/" and none of them expand it (whereas /bin/echo ~ is expanded). So I think it's reasonable to just follow every other shell here, are there other considerations for how tilde should behave on windows?

Also in a related area, the tab completion around tilde doesn't seem quite right - the behaviour from powershell 5 seems more correct to me.
Some cases I tried out, where $ is cursor position:

Case bash --norc (5.2) pwsh -NoProfile (7.4.0) powershell -NoProfile (5.1)

ls "~/my<tab> ls "/Users/user/my folder"/$ ls "~\my folder\$" ls "C:\Users\user\my folder\$"

ls ~/my<tab> ls ~/my\ folder/$ ls '~\my folder\$' ls 'C:\Users\user\my folder\$'

Seems like it is new (undesirable) behaviour in 7.4.0, some discussion about it here: #20750

POSIX-like shells only ever expand an unquoted argument-initial ~, either in isolation or if followed by a an unquoted username (not implemented in PowerShell - see #12387) or an unquoted /, and then possibly followed by an mix of unquoted and quoted strings (any mix of '...', "...", with their usual semantics), so I think that's what PowerShell should do as well - with the addition of also recognizing unquoted \, as stated in the initial post.

Thus, to ensure expansion of ~-prefixed paths parts of which require quoting, only the part after ~/ must be quoted; e.g. /bin/echo ~/'a test' (ditto in PowerShell) or /bin/echo ~/a\ test (/bin/echo ~/a` test in PowerShell)

Note that these cases are currently broken in PowerShell (which currently surface on Unix only):

Unix: Emulation of ~ (tilde) expansion for native utilities is syntactically incomplete #20754

They're also broken with respect to tab-completion, which inappropriately turns ~/'a test' into '~/a test', for instance: Broken tab-completion with file or directory names with spaces in the context of tilde-prefixed paths (~) #20851

Indeed, the problem described in #20750 effectively broke tab-completion of ~ on Windows for native-program calls, due to - by well-meaning design - no longer instantly expanding ~ to the value of $HOME.

This PR would make that problem go away - but to resolve #20750 this way (which I personally prefer) requires it to become a stable feature right away.

Find a summary of the solution options at:

7.4.0 Breaking Change: Tab expansion no longer converts tildes to full paths, breaking path passing to executables on Windows #20750 (comment)

@SteveL-MSFT i think this change just makes the UNIX and Windows behaviors similar, where ~ or ~/ would now behave consistently regardless of platform (it's cribbed from the code in lines 399-418). I would probably suggest #else rather than #endif at line 419 which might be clearer. We disambiguate between quoted and non-quoted ~ in lines after 344, so that would remain consistent. We don't currently treat ~ with regard to single and double quotes differently; if it's quoted, it's not expanded.

Now that I think on it, the concern I do have is that we would now have duplicated code which means a fix in one spot may not happen in the other. Perhaps this method should be refactored where we don't duplicate the code.

pull-request-quantifier-deprecated · 2023-12-14T12:04:08Z

This PR has 59 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Small
Size       : +48 -11
Percentile : 23.6%

Total files changed: 4

Change summary by file extension:
.cs : +23 -10
.ps1 : +23 -0
.json : +2 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

SteveL-MSFT

LGTM

JamesWTruher

nice!

bradwilson · 2024-02-12T21:52:31Z

@SteveL-MSFT @JamesWTruher @domsleee The fact that PowerShell on Linux quotes space-containing paths during tab expansion is broken behavior since 7.4.0, because it breaks translation of ~ when calling executables.

This PR will now break Windows in the same way, because of the same tab expansion behavior.

Additionally, trying to use PowerShell's native escaping for spaces to work around this behavior on Linux is also currently broken:

In my unvarnished opinion, the dumpster fire around tab expansion behavior with ~ introduced in 7.4.0 was ill thought out, and this one PR is not remotely a complete fix, even on Windows. Frankly: where are the test cases for all of this? How was this feature allowed out into the wild without realizing how many things were being broken, and how is the team working to resolve them before 7.5.0? The fact that the team has been 100% silent on #20750 is extremely disappointing, given that the issue has been open since November 2023. Will anybody ever respond?

mklement0 · 2024-02-12T22:02:55Z

While I share your frustration around the lack of responses / a decision on #20750,
what you're describing are known bugs that must be fixed separately and their existence is not an argument against the value or implementation of this PR:

Broken tab-completion with file or directory names with spaces in the context of tilde-prefixed paths (~) #20851
Unix: Emulation of ~ (tilde) expansion for native utilities is syntactically incomplete #20754

bradwilson · 2024-02-13T00:13:51Z

@mklement0 Not to be overly pessimistic, but neither of your issues have any comment from anybody on the team, either. Right now you're we're basically hoping they agree and create (or allow) a fix in time for 7.5.0.

mklement0 · 2024-02-13T00:19:24Z

Fair point, @bradwilson - let's hope that this exchange helps.

MatejKafka · 2024-03-09T20:37:39Z

The behavior of this implementation of tilde expansion seems utterly unintuitive to me and breaks basic assumptions that I (and I assume many other PowerShell users) have:

$Path = "~"
cmd /c echo $Path # C:\Users\admin
cmd /c echo "$Path" # ~

One of the things I like about PowerShell is that I don't have to think about quoting rules – if I want to pass a variable as a parameter, I just pass a parameter and don't worry about quoting. This feature breaks that, and means that whenever I'm passing a variable to a native command, I have to actively think whether I want to expand ~ and quote accordingly. PowerShell is complex enough as it is, and I don't see any way this feature can pull its weight. I disagree with the original implementation of this feature, where ~ was always expanded, but at least it was consistent, unlike this implementation.

I first encountered this feature when doing something like

ssh <host> cp ... ~/...

as part of a longer command and receiving mysterious errors that C:Usersadmin... is not an existing directory, which took me quite a lot of time to debug. I would not intuitively expect that ~ will be expanded in this context, much less so when it wrapped in a PowerShell function and the ~ is passed as a parameter.

In POSIX shells, ~ is expanded immediately when written, and not when passed to a native command:

x1=~
x2="~"
echo $x1 # /home/...
echo "$x1" # /home/...
echo $x2 # ~
echo "$x2" # ~

This is not ideal, but it is much more intuitive than expanding ~ in the command invocation. I understand why PowerShell cannot resolve ~ in the same way.

I'd personally happily sacrifice the resolution of ~ when calling native commands if it means that PowerShell quoting rules will remain simple and interact nicely with remote ssh calls and other places where literal ~ is passed. I understand that this is a bigger problem on Linux compared to Windows, but tab-expanding ~ seems like a safer, simpler and well-tested alternative.

mklement0 · 2024-03-09T20:59:27Z

The ssh example is an interesting one, as it mixes the worlds of Windows and Unix-like platforms.

Were you to run your example command on Unix, you would have to escape or quote the ~ to prevent instant expansion or - and with this feature you'll now need to do it on Windows too.

In POSIX-compatible shells, you'd have to do echo \~ or echo '~', for instance.
While /bin/echo '~' / cmd /c echo '~' also prevents instant expansion from PowerShell, the echo \~ equivalent, /bin/echo `~/ cmd /c echo `~ currently does not: see Unix-like platforms: native globbing and tilde expansion cannot be prevented with backtick-escaping #21304

Similarly, expansion still happening via variables - $p = "~"; /usr/bin/echo $p / $p = "~"; cmd /c echo $p should be considered a bug too, so I've created:

Unix-like platforms, Windows with the experimental PSNativeWindowsTildeExpansion feature: Native tilde expansion unexpectedly expands tilde in variable references #21323

MatejKafka · 2024-03-10T00:35:41Z

Were you to run your example command on Unix, you would have to escape or quote the ~ to prevent instant expansion or - and with this feature you'll now need to do it on Windows too.

Yes, but I use PowerShell because it's better than Unix shells. :)

More seriously, PowerShell takes different approach than Unix-style shells, and not having to quote variables is an important part of what makes PowerShell more intuitive and comfortable for daily usage. In Unix shells, you're expected to quote more-or-less everything, which is not expected in PowerShell, and this PR makes PowerShell quoting more complex, for imo lesser benefit.

I understand the desire for consistent ~ behavior between cmdlets and native commands, but adding special cases for quoting (a much more commonly used and core feature of PowerShell) to achieve that seems too great of a sacrifice to me.

* Bump xunit from 2.6.3 to 2.6.4 (PowerShell#20967) Bumps [xunit](https://github.com/xunit/xunit) from 2.6.3 to 2.6.4. - [Commits](xunit/xunit@2.6.3...2.6.4) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump xunit.runner.visualstudio from 2.5.5 to 2.5.6 (PowerShell#20966) Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.5 to 2.5.6. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.5.5...2.5.6) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Import-LocalizedData implicit Localization fallback (PowerShell#19896) * Adds culture fallback to Import-LocalizedData * Only add fallback if current culture is not en-US * Pester 4 compatibility * Missing param block in It * Missed param block for It * Skip UICulture name test for Linux and Mac * Removed test fragment * Fix typo in remotingexceptions.cs (PowerShell#21015) formating -> formatting * Fix failures in GitHub action `markdown-link-check` (PowerShell#20996) * Bump xunit from 2.6.4 to 2.6.5 (PowerShell#21008) * Include information about upgrading in README (PowerShell#20993) * Update the cgmanifest (PowerShell#20955) * Add `Aliases` to the properties shown up when formatting the help content of the parameter returned by `Get-Help` (PowerShell#20994) * Bump JsonSchema.Net from 5.4.2 to 5.5.0 (PowerShell#21027) * Fix regression -Tail 0 -Wait (PowerShell#20734) * Update README.md and metadata.json for v7.2.18 and v7.4.1 releases (PowerShell#21044) * Update changelog for v7.2 and v7.3 (PowerShell#21052) * Bump xunit from 2.6.5 to 2.6.6 (PowerShell#21071) * Bump StyleCop.Analyzers from 1.2.0-beta.507 to 1.2.0-beta.556 (PowerShell#20953) * Update to the latest NOTICES file (PowerShell#20905) * Update the cgmanifest (PowerShell#21047) * Fix completion crash for the SCCM provider (PowerShell#20915) * Bump .NET SDK to 8.0.101 (PowerShell#21084) * Add `WinGetCommandNotFound` and `CompletionPredictor` modules to track usage (PowerShell#21040) * Merged PR 29314: Update ChangeLog for v7.5.0-preview.1 Update ChangeLog for v7.5.0-preview.1 * Update `README.md` and `metadata.json` for v7.5.0-preview.1 release (PowerShell#21094) * Fix Get-Error serialization of array values (PowerShell#21085) Ensure Get-Error does not hang when attempting to serialize an exception that contains a property whose type is an array of System.Type instances. Also ensures that primitive types like System.Int32, System.Boolean as well as System.String is formatted as a string rather than an object with properties. * Validate the value for `using namespace` during semantic checks to prevent declaring invalid namespaces (PowerShell#21162) * Fix `using assembly` to use `Path.Combine` when constructing assembly paths (PowerShell#21169) * Add `DirectoryInfo` to the `OutputType` for `New-Item` (PowerShell#21126) * Bump JsonSchema.Net to v5.5.1 (PowerShell#21120) * Update changelog for v7.4.1 (PowerShell#21098) * Update WG members (PowerShell#21091) * Update the cgmanifest (PowerShell#21093) * Fix incorrect examples in XML docs in `PowerShell.cs` (PowerShell#21173) * Generate MSI for `win-arm64` installer (PowerShell#20516) * Rewrite the mac syslog tests to make them less flaky (PowerShell#21174) * Update versions of PSResourceGet (PowerShell#21190) * Add tilde expansion for windows native executables (PowerShell#20402) * Bump XunitXml.TestLogger from 3.1.17 to 3.1.20 (PowerShell#21207) * Remove `PSScheduledJob` module source code (PowerShell#21189) * Update to the latest NOTICES file (PowerShell#21177) * Update the cgmanifest (PowerShell#21178) * Fix a typo in `CoreAdapter.cs` (PowerShell#21179) * ConvertFrom-Json: Add -DateKind parameter (PowerShell#20925) Adds the -DateKind parameter to the ConvertFrom-Json that allows the caller to control how DateTime strings are converted into an object. The default behaviour is to create a DateTime value with the Kind being Unspecified if no TZ is set, Utc if the TZ Z is set, Local (after conversion) if an explicit TZ is set. This adds a Utc, Local to explicitly set the Kind as desired as well as a Offset and String value to create a DateTimeOffset or keep as a string. * Bump Microsoft.NET.Test.Sdk from 17.8.0 to 17.9.0 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.8.0 to 17.9.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.8.0...v17.9.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update dependabot.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Create codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Bump the nuget group across 1 directories with 1 update Bumps the nuget group with 1 update in the /test/tools/TestAlc/nested directory: [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json). Updates `Newtonsoft.Json` from 10.0.1 to 13.0.1 - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](JamesNK/Newtonsoft.Json@10.0.1...13.0.1) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Bump PowerShellGet from 2.2.5 to 2.2.5.1 in /src/Modules Bumps [PowerShellGet](https://github.com/PowerShell/PowerShellGet) from 2.2.5 to 2.2.5.1. - [Changelog](https://github.com/PowerShell/PowerShellGet/blob/master/CHANGELOG.md) - [Commits](https://github.com/PowerShell/PowerShellGet/commits) --- updated-dependencies: - dependency-name: PowerShellGet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump to .NET 9 Preview 1 (PowerShell#21229) * Update the cgmanifest (PowerShell#21237) * Update to the latest NOTICES file (PowerShell#21236) * Update experimental-feature json files (PowerShell#21213) * Remove `surrogateFile` setting of APIScan (PowerShell#21238) * Add dotenv install as latest version does not work with current Ruby version (PowerShell#21239) * Bump xunit from 2.6.6 to 2.7.0 Bumps [xunit](https://github.com/xunit/xunit) from 2.6.6 to 2.7.0. - [Commits](xunit/xunit@2.6.6...2.7.0) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump xunit.runner.visualstudio from 2.5.6 to 2.5.7 Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.6 to 2.5.7. - [Release notes](https://github.com/xunit/visualstudio.xunit/releases) - [Commits](xunit/visualstudio.xunit@2.5.6...2.5.7) --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Add dotnet-runtime-9.0 as a dependency for the Mariner package (PowerShell#21259) * Adding WG membership template (PowerShell#21153) * Adding WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Editing WG membership template * Update .github/ISSUE_TEMPLATE/WG_member_request.yaml Co-authored-by: Steve Lee <slee@microsoft.com> * Update .github/ISSUE_TEMPLATE/WG_member_request.yaml Co-authored-by: Steve Lee <slee@microsoft.com> --------- Co-authored-by: Jason.Helmick <jahelmic@microsoft.com> Co-authored-by: Steve Lee <slee@microsoft.com> * Update `metadata.json` and `README.md` (PowerShell#21264) * Skip test on Windows Server 2012 R2 for `no-nl` (PowerShell#21265) * Fix a regression in `Format-Table` when header label is empty (PowerShell#21156) * Revert "Adjust PUT method behavior to POST one for default content type in WebCmdlets" (PowerShell#21049) * Fix the regression when doing type inference for `$_` (PowerShell#21223) * ConvertTo-Json: Serialize `BigInteger` as a number (PowerShell#21000) * Remove `JetBrains.Annotations` attributes (PowerShell#21246) * Suppress MacOS package manager output (PowerShell#21244) * Enable CA1868: Unnecessary call to 'Contains' for sets (PowerShell#21165) https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1868 * Bump Microsoft.CodeAnalysis.CSharp from 4.8.0 to 4.9.2 Bumps [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn) from 4.8.0 to 4.9.2. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Microsoft.CodeAnalysis.Analyzers (PowerShell#21297) * Bump Microsoft.CodeAnalysis.CSharp from 4.9.0-3.final to 4.9.2 (PowerShell#21298) * Fix error formatting for pipeline enumeration exceptions (PowerShell#20211) * Fall back to type inference when hashtable key value cannot be retrieved from safe expression (PowerShell#21184) * Get-Process: Remove admin requirement for `-IncludeUserName` (PowerShell#21302) * Bump Microsoft.CodeAnalysis.Analyzers (PowerShell#21305) * Fix a typo in `releaseTools.psm1` (PowerShell#21306) * Fix PowerShell class to support deriving from an abstract class with abstract properties (PowerShell#21331) * Handle the case that `Runspace.DefaultRunspace is null` when logging for WDAC Audit (PowerShell#21344) * Make sure both stdout and stderr can be redirected from a native executable (PowerShell#20997) * Fix typo in ast.cs (PowerShell#21350) statment -> statement * Make sure the assembly/library resolvers are registered at early stage (PowerShell#21361) * Revert the PR PowerShell#17856 (Do not preserve temporary results when no need to do so) (PowerShell#21368) * Add file description to `pwsh.exe` (PowerShell#21352) * PowerShell co-ordinated build OneBranch pipeline (PowerShell#21364) * Fix argument passing in `GlobalToolShim` (PowerShell#21333) * Fix build failure due to missing reference in `GlobalToolShim.cs` (PowerShell#21388) * Fix typo in a test (PowerShell#21337) connectiong -> connecting * Fix `Test-Path -IsValid` to check for invalid path and filename characters (PowerShell#21358) * Fix typo in SessionStateCmdletAPIs.cs (PowerShell#21413) hte -> the * Update `PSReadLine` to `v2.3.5` for the next `v7.4.x` servicing release (PowerShell#21414) * Multiple fixes in official build pipeline (PowerShell#21408) * Add back two transitive dependency packages (PowerShell#21415) * Verify environment variable for OneBranch before we try to copy (PowerShell#21441) * Update PSResourceGet version from 1.0.2 to 1.0.4.1 (PowerShell#21439) * fix package build to not check some files for a signature. (PowerShell#21458) * Update `metadata.json` and `README.md` (PowerShell#21454) * Fix grammar in FAQ.md (PowerShell#21468) Fix grammar in docs FAQ * Update CHANGELOG for v7.2.19, v7.3.12 and v7.4.2 (PowerShell#21462) * Fix the error when using `Start-Process -Credential` without the admin privilege (PowerShell#21393) * Add `RecommendedAction` to `ConciseView` of the error reporting (PowerShell#20826) * Update Engine & Interactive-UX Working Group Member lists (PowerShell#20991) * Bump `Microsoft.CodeAnalysis.Analyzers` (PowerShell#21449) * Don't complete parameter name and class member declarations (PowerShell#21182) * Update the doc about how to build PowerShell (PowerShell#21334) * [StepSecurity] Apply security best practices (PowerShell#21480) * [StepSecurity] Apply security best practices Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> * Update dependabot.yml * Delete tools/releaseBuild/Images/microsoft_powershell_centos7 directory * Delete tools/releaseBuild/Images/microsoft_powershell_ubuntu16.04 directory * Delete tools/releaseBuild/Images/microsoft_powershell_ubuntu18.04 directory * Delete tools/releaseBuild/Images/microsoft_powershell_windowsservercore/Dockerfile --------- Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> * Bump ossf/scorecard-action from 2.0.6 to 2.3.1 (PowerShell#21485) * Bump ossf/scorecard-action from 2.0.6 to 2.3.1 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.6 to 2.3.1. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@99c5375...0864cf1) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update windows.yml * Update linux.yml * Update windows.yml * Update mac.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> * Bump actions/upload-artifact from 3.1.3 to 4.3.2 (PowerShell#21501) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.3.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@a8a3f3a...1746f4a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.25.0 to 3.25.1 (PowerShell#21498) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.25.0 to 3.25.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v2.25.0...c7f9125) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.6.0 to 4.1.2 (PowerShell#21482) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.1.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.6.0...9bb5618) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/dependency-review-action from 2.5.1 to 4.2.5 (PowerShell#21484) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 2.5.1 to 4.2.5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@0efb1d1...5bbc3ba) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add a PAT for fetching PMC cli (PowerShell#21503) * Use new pat * remove trailing whitespaces * Fix `[semver]` type to pass semver.org tests (PowerShell#21401) * Fix `[semver]` type to pass semver.org tests * fix test to split per OS specific newline * replace all regex with semver.org ones adding new one for build label, update tests --------- Co-authored-by: Steve Lee (POWERSHELL HE/HIM) (from Dev Box) <slee@ntdev.microsoft.com> * Separate DSC configuration parser check for ARM processor (PowerShell#21395) * Official PowerShell Package pipeline (PowerShell#21504) * Revert to version available on `Nuget` for `Microsoft.CodeAnalysis.Analyzers` (PowerShell#21515) * Use correct signing certificates for RPM and DEBs (PowerShell#21522) * Add branch counter variables for daily package builds (PowerShell#21523) * Expand `~` to `$home` on Windows with tab completion (PowerShell#21529) * Bump github/codeql-action from 3.25.1 to 3.25.3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.1 to 3.25.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@c7f9125...d39d31e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/checkout from 4.1.2 to 4.1.4 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@9bb5618...0ad4b8f) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump actions/upload-artifact from 4.3.2 to 4.3.3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@1746f4a...6546280) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump super-linter/super-linter from 5.7.2 to 6.4.1 Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 5.7.2 to 6.4.1. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](super-linter/super-linter@a8150b4...4758be6) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Delete .github/workflows/codeql-analysis.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Update codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Update codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Delete .github/workflows/codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Bump actions/dependency-review-action from 4.2.5 to 4.3.2 Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.2.5 to 4.3.2. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@5bbc3ba...0c155c5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update wix package install (PowerShell#21537) * Create the Windows.x64 global tool with shim for signing (PowerShell#21559) * Fix generating `OutputType` when running in Constrained Language Mode (PowerShell#21605) * Use PSScriptRoot to find path to Wix module (PowerShell#21611) * Bump actions/checkout from 4.1.4 to 4.1.5 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@0ad4b8f...44c2b7a) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Remember installation options and used them to initialize options for the next installation (PowerShell#20420) * Bump github/codeql-action from 3.25.3 to 3.25.4 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.3 to 3.25.4. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d39d31e...ccf74c9) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump to .NET 9 preview 3 (PowerShell#21782) * Bump ossf/scorecard-action from 2.3.1 to 2.3.3 Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.1 to 2.3.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@0864cf1...dc50aa9) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Use feed with Microsoft Wix toolset (PowerShell#21651) * Create codeql.yml Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> * Bump super-linter/super-linter from 6.4.1 to 6.5.0 Bumps [super-linter/super-linter](https://github.com/super-linter/super-linter) from 6.4.1 to 6.5.0. - [Release notes](https://github.com/super-linter/super-linter/releases) - [Changelog](https://github.com/super-linter/super-linter/blob/main/CHANGELOG.md) - [Commits](super-linter/super-linter@4758be6...56576d4) --- updated-dependencies: - dependency-name: super-linter/super-linter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Matthew Tanner <imatthewtanner@icloud.com> Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Dent <134605137+chrisdent-de@users.noreply.github.com> Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com> Co-authored-by: James Truher [MSFT] <jimtru@microsoft.com> Co-authored-by: Steven Bucher <stevenbucher8@gmail.com> Co-authored-by: PowerShell Team Bot <69177312+pwshBot@users.noreply.github.com> Co-authored-by: Dongbo Wang <dongbow@microsoft.com> Co-authored-by: CarloToso <105941898+CarloToso@users.noreply.github.com> Co-authored-by: MartinGC94 <42123497+MartinGC94@users.noreply.github.com> Co-authored-by: Jordan Borean <jborean93@gmail.com> Co-authored-by: Greg Dennis <gregsdennis@yahoo.com> Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com> Co-authored-by: Anam Navied <anam.naviyou@gmail.com> Co-authored-by: alerickson <25858831+alerickson@users.noreply.github.com> Co-authored-by: Dom Slee <domslee1@gmail.com> Co-authored-by: Steve Lee <slee@microsoft.com> Co-authored-by: Aditya Patwardhan <adityap@microsoft.com> Co-authored-by: Jason Helmick <jason.helmick@microsoft.com> Co-authored-by: Jason.Helmick <jahelmic@microsoft.com> Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Co-authored-by: Friedrich von Never <friedrich@fornever.me> Co-authored-by: guangwu <guoguangwu@magic-shield.com> Co-authored-by: Roshan Ganesh <73138775+CodingGod987@users.noreply.github.com> Co-authored-by: Justin Grote <JustinGrote@users.noreply.github.com> Co-authored-by: Ryan Yates <ryan.yates@kilasuit.org> Co-authored-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Steve Lee (POWERSHELL HE/HIM) (from Dev Box) <slee@ntdev.microsoft.com> Co-authored-by: David Kontyko <33853225+dkontyko@users.noreply.github.com> Co-authored-by: Tess Gauthier <tgauth@bu.edu> Co-authored-by: Dave <reduckted@outlook.com>

pull-request-quantifier-deprecated bot added the Extra Small label Sep 29, 2023

domsleee marked this pull request as ready for review September 30, 2023 03:50

domsleee mentioned this pull request Oct 2, 2023

Cannot lsd ~ on windows lsd-rs/lsd#903

Open

SteveL-MSFT added the CommunityDay-Small A small PR that the PS team has identified to prioritize to review label Oct 2, 2023

SteveL-MSFT requested changes Oct 2, 2023

View reviewed changes

microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 2, 2023

domsleee force-pushed the feature/windows-tilde branch from f41b83a to 7aabb18 Compare October 3, 2023 11:34

domsleee requested review from daxian-dbw, TravisEz13, adityapatwardhan and anmenaga as code owners October 3, 2023 11:34

microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 3, 2023

domsleee requested a review from SteveL-MSFT October 4, 2023 00:22

StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Oct 9, 2023

microsoft-github-policy-service bot added Review - Needed The PR is being reviewed labels Oct 17, 2023

SteveL-MSFT requested changes Dec 4, 2023

View reviewed changes

domsleee mentioned this pull request Dec 5, 2023

7.4.0 Breaking Change: Tab expansion no longer converts tildes to full paths, breaking path passing to executables on Windows #20750

Closed

5 tasks

This was referenced Dec 5, 2023

Broken tab-completion with file or directory names with spaces in the context of tilde-prefixed paths (~) #20851

Open

windows: '~' Home reference bug #20761

Open

domsleee added 2 commits December 14, 2023 21:26

Introduce 'PSNativeWindowsTildeExpansion' to expand tilde on windows

18e8753

Group windows + linux tilde expansion logic

468e678

domsleee force-pushed the feature/windows-tilde branch 3 times, most recently from 600b89d to a7270cf Compare December 14, 2023 11:25

Fix codefactor issues

a6be29c

pull-request-quantifier-deprecated bot added Small and removed Extra Small labels Dec 14, 2023

domsleee force-pushed the feature/windows-tilde branch from a7270cf to a6be29c Compare December 14, 2023 11:30

Remove unused using

768f92c

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Dec 21, 2023

SteveL-MSFT approved these changes Jan 8, 2024

View reviewed changes

SteveL-MSFT assigned adityapatwardhan Jan 8, 2024

microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Jan 8, 2024

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jan 15, 2024

rkeithhill mentioned this pull request Feb 5, 2024

Powershell does not expand '~' for external programs #20031

Closed

5 tasks

JamesWTruher approved these changes Feb 12, 2024

View reviewed changes

daxian-dbw merged commit c56a52b into PowerShell:master Feb 12, 2024
34 checks passed

microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Feb 12, 2024

daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 12, 2024

jborean93 mentioned this pull request Feb 14, 2024

ConvertTo-Json: Treat large enums as numbers #20999

Merged

22 tasks

dkattan pushed a commit to dkattan/PowerShell that referenced this pull request Feb 19, 2024

Add tilde expansion for windows native executables (PowerShell#20402)

2dbed93

SteveL-MSFT mentioned this pull request Apr 3, 2024

when using -p to pass a file ~ cannot be used in PowerShell PowerShell/DSC#365

Open

3 tasks

chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024

Add tilde expansion for windows native executables (PowerShell#20402)

382559c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tilde expansion for windows native executables #20402

Add tilde expansion for windows native executables #20402

domsleee commented Sep 29, 2023 •

edited

Loading

domsleee commented Sep 29, 2023

domsleee commented Sep 29, 2023

SteveL-MSFT left a comment

SteveL-MSFT Dec 4, 2023

domsleee Dec 5, 2023

mklement0 Dec 6, 2023

JamesWTruher Dec 11, 2023

pull-request-quantifier-deprecated bot commented Dec 14, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

SteveL-MSFT left a comment

JamesWTruher left a comment

bradwilson commented Feb 12, 2024

mklement0 commented Feb 12, 2024

bradwilson commented Feb 13, 2024

mklement0 commented Feb 13, 2024

MatejKafka commented Mar 9, 2024

mklement0 commented Mar 9, 2024

MatejKafka commented Mar 10, 2024 •

edited

Loading

	/bin/echo '~' \| Should -BeExactly '~'
	/bin/echo "~" \| Should -BeExactly '~'
	/bin/echo '~/foo' \| Should -BeExactly '~/foo'
	/bin/echo "~/foo" \| Should -BeExactly '~/foo'

Case	`bash --norc` (5.2)	`pwsh -NoProfile` (7.4.0)	`powershell -NoProfile` (5.1)
`ls "~/my<tab>`	`ls "/Users/user/my folder"/$`	`ls "~\my folder\$"`	`ls "C:\Users\user\my folder\$"`
`ls ~/my<tab>`	`ls ~/my\ folder/$`	`ls '~\my folder\$'`	`ls 'C:\Users\user\my folder\$'`

Add tilde expansion for windows native executables #20402

Add tilde expansion for windows native executables #20402

Conversation

domsleee commented Sep 29, 2023 • edited Loading

PR Summary

PR Context

PR Checklist

domsleee commented Sep 29, 2023

domsleee commented Sep 29, 2023

SteveL-MSFT left a comment

Choose a reason for hiding this comment

SteveL-MSFT Dec 4, 2023

Choose a reason for hiding this comment

domsleee Dec 5, 2023

Choose a reason for hiding this comment

mklement0 Dec 6, 2023

Choose a reason for hiding this comment

JamesWTruher Dec 11, 2023

Choose a reason for hiding this comment

pull-request-quantifier-deprecated bot commented Dec 14, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

SteveL-MSFT left a comment

Choose a reason for hiding this comment

JamesWTruher left a comment

Choose a reason for hiding this comment

bradwilson commented Feb 12, 2024

mklement0 commented Feb 12, 2024

bradwilson commented Feb 13, 2024

mklement0 commented Feb 13, 2024

MatejKafka commented Mar 9, 2024

mklement0 commented Mar 9, 2024

MatejKafka commented Mar 10, 2024 • edited Loading

domsleee commented Sep 29, 2023 •

edited

Loading

MatejKafka commented Mar 10, 2024 •

edited

Loading