Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include node names when sending telemetry. #16981

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Do not include node names when sending telemetry. #16981

merged 3 commits into from
Apr 14, 2022
+25 −4

Conversation

JamesWTruher
Copy link
Collaborator

PR Summary

This uses a telemetry initializer to obscure the node name when sending telemetry
as setting it explicitly in the telemetry client does not work.

PR Context

Addresses issue reported in Twitter where we're still reporting the name of the computer in the role instance.

PR Checklist

Sorry, something went wrong.

@JamesWTruher
Do not include node names when sending telemetry.
a8a0cd9 
This uses a telemetry initializer to obscure the node name when sending telemetry
as setting it explicitly in the telemetry client does not work.
@ghost ghost assigned anmenaga Mar 9, 2022
@SteveL-MSFT SteveL-MSFT mentioned this pull request Mar 9, 2022
Closed
22 tasks
@pull-request-quantifier-deprecated
Copy link

This PR has 12 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +9 -3
Percentile : 4.8%

Total files changed: 1

Change summary by file extension:
.cs : +9 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

PaulHigin
PaulHigin approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 assigned TravisEz13 and unassigned anmenaga Mar 14, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Mar 23, 2022
@ghost
Copy link

ghost commented Mar 23, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Mar 29, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 6, 2022
@ghost
Copy link

ghost commented Apr 6, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@anmenaga anmenaga removed the Review - Needed The PR is being reviewed label Apr 14, 2022
@anmenaga anmenaga merged commit 84e73b2 into PowerShell:master Apr 14, 2022
@ghost
Copy link

ghost commented Apr 26, 2022

🎉v7.0.10 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 26, 2022

🎉v7.1.7 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 26, 2022

🎉v7.2.3 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Apr 28, 2022
@anmenaga
Merged PR 20188: Do not include node names when sending telemetry. (P…
82b1e39 
…owerShell#16981) to v7.2.3

Do not include node names when sending telemetry. (PowerShell#16981)
PowerShell#16981
TravisEz13 pushed a commit that referenced this pull request Apr 29, 2022
@anmenaga
Merged PR 20186: Do not include node names when sending telemetry. (#…
48326a7 
…16981) to v7.0.10

Do not include node names when sending telemetry. (#16981)
#16981
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
@JamesWTruher JamesWTruher deleted the TelemetryNodeNameAsNA branch September 23, 2023 05:36
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT

@PaulHigin PaulHigin

@TravisEz13 TravisEz13

Assignees

@TravisEz13 TravisEz13

Labels
Backport-7.0.x-Done BackPort-7.1.x-Done Backport to 7.1.x completed Backport-7.2.x-Done Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JamesWTruher @SteveL-MSFT @PaulHigin @TravisEz13 @anmenaga