Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade APIScan version #12876

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Upgrade APIScan version #12876

merged 1 commit into from
Jun 4, 2020

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jun 3, 2020 •
edited
Loading

PR Summary

APIScan tool version must be upgraded.

PR Context

Using older version is not compliant.

PR Checklist

@ghost ghost assigned anmenaga Jun 3, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 3, 2020
@adityapatwardhan
Copy link
Member Author

@PoshChan please rebuild all

@PoshChan
Copy link
Collaborator

PoshChan commented Jun 3, 2020

@adityapatwardhan, did not find matching build context: PowerShell-CI-Windows; allowed contexts: PowerShell-CI-static-analysis

PoshChan
PoshChan reviewed Jun 3, 2020
View reviewed changes
tools/releaseBuild/azureDevOps/templates/compliance.yml
@@ -99,7 +99,7 @@ jobs:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityapatwardhan, your last commit had 1 failures in PowerShell-CI-static-analysis
Verify Markdown Links.Verify links in /home/vsts/work/1/s/README.md.https://powershell.visualstudio.com/PowerShell/_build/latest?definitionId=32 should work

Failed to complete request to "https://powershell.visualstudio.com/PowerShell/_build/latest?definitionId=32". Response status code does not indicate success: 404 (Not Found).
at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119
119:                                     throw "Failed to complete request to `"$url`". $($_.Exception.Message)"

@adityapatwardhan
Copy link
Member Author

@PoshChan please retry static

@PoshChan
Copy link
Collaborator

PoshChan commented Jun 4, 2020

@adityapatwardhan, successfully started retry of PowerShell-CI-static-analysis

@adityapatwardhan adityapatwardhan added this to the 7.1.0-preview.4 milestone Jun 4, 2020
@adityapatwardhan adityapatwardhan merged commit 01616df into PowerShell:master Jun 4, 2020
@adityapatwardhan adityapatwardhan deleted the APIScanv3 branch June 4, 2020 16:58
@TravisEz13 TravisEz13 modified the milestones: 7.1.0-preview.4, 6.2.6 Jun 8, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

🎉v6.2.6 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jun 11, 2020

🎉v7.0.2 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Jun 11, 2020
Merged
Merged
Merged
Merged
Closed
Closed
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

silijon pushed a commit to SkyKick/PowerShell that referenced this pull request Jul 2, 2020
@adityapatwardhan @TravisEz13
Upgrade APIScan version (PowerShell#12876)
59733d9
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoshChan PoshChan

@TravisEz13 TravisEz13

@anmenaga anmenaga

@daxian-dbw daxian-dbw

Assignees

@anmenaga anmenaga

Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
6.2.6
Development

Successfully merging this pull request may close these issues.
4 participants
@adityapatwardhan @PoshChan @TravisEz13 @anmenaga