CMake: Search for Threads in the installed config. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `find_package(PortMidi)` would fail due to `Threads::Threads` being in the target's interface but not available.
|
Thanks for the fix. I don't use, test, or maintain CMake configuration facilities, but I'm happy to have them there for others. Contributions and improvements in this area are especially appreciated. |
|
Thank you for your comment. I am confused as to why this PR was closed, are you planning on adding this change manually? Are there any changes you wanted for this PR? The issue is that, as it stands, downstream users cannot use PortMidi in CMake out of the box (outside of Windows). |
|
Sorry - I thought I hit the merge button. I think it's done now. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to consume
PortMidiin CMake on platforms linking againstThreads::Threadscurrently fails with the following error message:This is due to
Threadsnot being searched in the installed Config file.