cmake: patch asiolist.cpp as issue #331 explains #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. This is a good thing to fix. It would be better to not modify the user's files in place. As a suggestion, perhaps we could create the patched version of |
|
Done |
RossBencina
reviewed
Feb 6, 2025
philburk
approved these changes
Feb 6, 2025
RossBencina
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Due to severity of the issue and the effectiveness of the fix, we're going to merge this as-is. However it could be improved further, as noted by new issue #1004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If download of ASIO api is complete, this performs the modification of "delete lpdrv" to "delete[] lpdrv".
Even in the case it was already done that would be harmless.