Supervoxel coloring update #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would keep |
jpapon
force-pushed
the
supervoxel_coloring_update
branch
from
4e2238d to
62f0d7e
Compare
|
Done. |
| pcl::io::PointCloudImageExtractorFromLabelField<PointLT> pcie (pcie.io::PointCloudImageExtractorFromLabelField< PointLT>::COLORS_RGB_GLASBEY); | ||
| pcl::PCLImage image; | ||
| pcie.extract (*full_labeled_cloud, image); | ||
| pcl::io::savePNGFile(out_path, image); |
|
Can you squash the fixup commits? Then I'll merge. |
…use the label field handlers from PointCloudLibrary#849 , deprecated functions return empty cloud to deprecated functions to avoid warnings Changed labeled color handler to use modulo max color instead of using random colors
jpapon
force-pushed
the
supervoxel_coloring_update
branch
from
46cd0e5 to
81e8664
Compare
|
gesquashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes supervoxel clustering so that it uses the changes from #849 (new label color handler).
The functions for getting RGB clouds have been deprecated, and the example updated.
The label color handler was also updated so that it uses modulo the max label, rather than random colors. This fixes the problem where colors change if the cloud is updated and is faster.
Also, spacing in the header file was fixed so git doesn't complain anymore.