Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 of the 3 files which cause gcc to warn about misleading-intentation. Small changes, but
auxiliary.h
is included several times causing duplicate warnings.Compiling with gcc 7.2.1 gave 159 warnings (only 78 of which were unique).
This pull request fixes 23 warnings.
I've put them into two commits, which I can rebase and squash before merging.
For the file which I didn't fix in this pull request, 3 misleading indentation warnings remain.
I can fix and add to this, but first I just wanted to ask for feedback.
The 3rd is
outofcore/src/cJSON.cpp
lines 41 & 469 are easy.line 496 not so straightforward to maintain the style of that file- which seems to like piling lines of code on the same line.