Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing more utilities so that users can interact with a PerspectiveProxyRayServer #25

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

timkpaine
Copy link
Member

Moved from #19

image

So this is truly just an RFC, but some conversations around further emphasizing a the perspective component of things without requiring a RayTaskTracker object were happening, and this diff is up to facilitate those discussions.

@gauglertodd gauglertodd force-pushed the tbg/expose-perspective-proxy-server branch 5 times, most recently from d73ee5a to 00076e1 Compare September 4, 2024 15:53
Copy link

github-actions bot commented Sep 4, 2024

Test Results

2 tests  +1   2 ✅ +1   45s ⏱️ +10s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 83acac2. ± Comparison against base commit 26a9c97.

♻️ This comment has been updated with latest results.

@gauglertodd gauglertodd force-pushed the tbg/expose-perspective-proxy-server branch 2 times, most recently from dc1b042 to 27d46d3 Compare September 4, 2024 16:20
@gauglertodd gauglertodd marked this pull request as ready for review September 5, 2024 21:55
@gauglertodd
Copy link
Collaborator

feels lame without a test, let me add one

@gauglertodd gauglertodd force-pushed the tbg/expose-perspective-proxy-server branch from 27d46d3 to 946d987 Compare September 6, 2024 02:22
@gauglertodd gauglertodd changed the title [RFC] Exposing more utilities so that users can interact with a PerspectiveProxyRayServer Exposing more utilities so that users can interact with a PerspectiveProxyRayServer Sep 6, 2024
@gauglertodd gauglertodd force-pushed the tbg/expose-perspective-proxy-server branch 4 times, most recently from 27086c1 to 564e629 Compare September 9, 2024 15:05
…ectiveProxyRayServer

...

...

...

...

.

Signed-off-by: Todd Gaugler <todd.gaugler@cubistsystematic.com>

adding tests

...

...

.

.

.
@gauglertodd gauglertodd force-pushed the tbg/expose-perspective-proxy-server branch from 564e629 to 83acac2 Compare September 9, 2024 15:07
@gauglertodd gauglertodd merged commit f689ff8 into main Sep 9, 2024
1 check passed
@gauglertodd gauglertodd deleted the tbg/expose-perspective-proxy-server branch September 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants