websocket - raise a clear error is hostname isnt extracted from URI (… #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robambalu
requested review from
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
AdamGlustein
previously approved these changes
Jun 26, 2024
| @@ -24,6 +24,10 @@ def g(uri: str): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| if len(sys.argv) != 2: | |||
| print( f'Usage: e1_websocket_client <uri>') | |||
There was a problem hiding this comment.
Can you just run make fix so the builds pass?
… crashes otherwise ). Add Usage to example Signed-off-by: Rob Ambalu <robert.ambalu@point72.com>
robambalu
force-pushed
the
rba/websocket_minor_cleanup
branch
from
6878a33 to
322abef
Compare
AdamGlustein
approved these changes
Jun 26, 2024
timkpaine
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… crashes otherwise ). Add Usage to example.