Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docs lints on PRs that change docs, add new logo, clean up unofficial roadmap #167

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Run docs lints on PRs that change docs, add new logo, clean up unofficial roadmap #167

merged 4 commits into from
Apr 2, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Mar 26, 2024 •
edited
Loading

this PR does 3 things:

  • Previously we were ignoring builds on docs-only changes in order to conserve CI resources. However, we have docs lints that need to run, otherwise a docs-only PR might be merged and break the build due to lint errors. This PR separates out a docs lint workflow to run on PRs that change docs/** or README.md
  • Update the logo while Documentation Restructure #142 is being worked on
  • Update the unofficial roadmap, which even though it has not been worked out, has already become a bit stale

@timkpaine
Add new logo, clean up unofficial roadmap
d1f54b1 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine added the part: documentation Improvements/bugs/changes to documentation label Mar 26, 2024
@timkpaine
Conserver CI resources by ignoring all changes to docs
edbe065 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine requested a review from czgdp1807 as a code owner March 26, 2024 19:52
@timkpaine timkpaine marked this pull request as draft March 26, 2024 20:04
@timkpaine
tweak github actions to run docs lints on PRs that change docs
d7da202 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine
Fix documentation lints
f1169db 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine changed the title Add new logo, clean up unofficial roadmap Run docs lints on PRs that change docs, add new logo, clean up unofficial roadmap Mar 26, 2024
@timkpaine timkpaine marked this pull request as ready for review March 26, 2024 20:11
@timkpaine timkpaine mentioned this pull request Apr 1, 2024
Merged
@timkpaine timkpaine merged commit b1b9916 into main Apr 2, 2024
17 checks passed
@timkpaine timkpaine deleted the tkp/docs branch April 2, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu approved these changes

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

Assignees
No one assigned
Labels
part: documentation Improvements/bugs/changes to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @robambalu