Clang 13 less warnings #1684
Open
Clang 13 less warnings #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-7025 |
charlesfleche
force-pushed
the
clang-13-no-warning
branch
from
57298f2
to
e196d7d
Compare
charlesfleche
force-pushed
the
clang-13-no-warning
branch
from
e196d7d
to
7788e6f
Compare
pixar-oss
pushed a commit
that referenced
this pull request
Feb 16, 2023
These were flagged as warnings by clang 13 since the other virtual functions in these classes were marked as overrides. This is part of PR #1684 from @charlesfleche (Internal change: 2262989)
pixar-oss
pushed a commit
that referenced
this pull request
Feb 16, 2023
This was flagged as a warning by clang 13. This is part of PR #1684 from @charlesfleche (Internal change: 2263052)
pixar-oss
pushed a commit
that referenced
this pull request
Feb 16, 2023
This is part of PR #1684 from @charlesfleche (Internal change: 2263141)
pixar-oss
pushed a commit
that referenced
this pull request
Mar 2, 2023
This fixes memory leaks in usdDraco due to deleting derived class via a base class pointer. This is part of PR #1684 from @charlesfleche (Internal change: 2263942)
pixar-oss
pushed a commit
that referenced
this pull request
Mar 14, 2023
This change guards unused private members that exist purely for ABI compatibility between USD builds with and without Python support enabled (see #1716) with a new pragma to disable warnings on clang. Part of PR #1684 from @charlesfleche (Internal change: 2265598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Trying to compile USD with clang 13 raised a few new warnings. This PR fixes most of them. I tried to group the fixes for a given warning as much as possible for easier cherry-picking.
Fixes Issue(s)