[usdImagingGL,usdview] Add support to set the OCIO display, view, and colorspace #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-6656 |
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
- Rename testUsdviewOCIO to testUsdviewColorManagement and extend test to validate all color management options (disabled, sRGB and OCIO). - Set env var during test run. - Add test to CMake. See #1491 (Internal change: 2193575)
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
See #1491 (Internal change: 2193845)
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
See #1491 (Internal change: 2194152)
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
... that uses a different view. See #1491 (Internal change: 2194613)
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
- Disable *openColorIO* from the *Color Management* menu when the OCIO env var isn't specified. - Fix data flow to handle changes to OCIO config via API. _refreshColorCorrectionModeMenu() updates the UI when the relevant view settings are changed. - Update API used in test. Note that the OCIO settings aren't saved to session state yet since the settings are associated with the config file used. Fixes #1491 (Internal change: 2194935)
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
See #1491 (Internal change: 2197560)
pixar-oss
pushed a commit
that referenced
this pull request
Nov 5, 2021
See #1491 (Internal change: 2197794)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
- Rename testUsdviewOCIO to testUsdviewColorManagement and extend test to validate all color management options (disabled, sRGB and OCIO). - Set env var during test run. - Add test to CMake. See PixarAnimationStudios#1491 (Internal change: 2193575)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
See PixarAnimationStudios#1491 (Internal change: 2193845)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
See PixarAnimationStudios#1491 (Internal change: 2194152)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
... that uses a different view. See PixarAnimationStudios#1491 (Internal change: 2194613)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
- Disable *openColorIO* from the *Color Management* menu when the OCIO env var isn't specified. - Fix data flow to handle changes to OCIO config via API. _refreshColorCorrectionModeMenu() updates the UI when the relevant view settings are changed. - Update API used in test. Note that the OCIO settings aren't saved to session state yet since the settings are associated with the config file used. Fixes PixarAnimationStudios#1491 (Internal change: 2194935)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
See PixarAnimationStudios#1491 (Internal change: 2197560)
lkerley
pushed a commit
to imageworks/USD
that referenced
this pull request
Jan 7, 2022
See PixarAnimationStudios#1491 (Internal change: 2197794)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're testing more assets and images in usdview, there have been some request to be able to actual configure OCIO.
Additionally some internal usage of usdImagingGL will benefit from being able to tweak the profile in use.
For usdview:
Description of Change(s)
Just pushes through some string to the right place to get picked up in HdxColorCorrectionTaskParams
Dynamically builds an OpenColorIO menu in usdview based on the current config if PyOpenColorIO is available.
Open to suggestions on how to make this better.