Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF_PP_CAT can be used to make some files not depend on boost/preprocessor #2247

Closed
nvmkuruc opened this issue Feb 7, 2023 · 3 comments
Closed

TF_PP_CAT can be used to make some files not depend on boost/preprocessor #2247

nvmkuruc opened this issue Feb 7, 2023 · 3 comments

Comments

@nvmkuruc
Copy link
Collaborator

nvmkuruc commented Feb 7, 2023 •
edited
Loading

Description of Issue

pxr/usd/pcp/diagnostic.h and pxr/base/tf/pyModule.h bring in the boost/preprocessor library solely for BOOST_PP_CAT.

Using TF_PP_CAT in these cases reduces the dependencies on boost/preprocessor.

Steps to Reproduce

N/A

System Information (OS, Hardware)

N/A

Package Versions

N/A

Build Flags

N/A
@nvmkuruc
Copy link
Collaborator Author

nvmkuruc commented Feb 7, 2023

I have a fix.

@nvmkuruc nvmkuruc mentioned this issue Feb 7, 2023
Merged
2 tasks
@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-7981

@nvmkuruc nvmkuruc mentioned this issue Sep 5, 2023
Merged
2 tasks
@nvmkuruc
Copy link
Collaborator Author

This was addressed by #2645 and #2249

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tallytalwar @nvmkuruc