Remove mLabelRotatedHeight counted twice, when calculating legend offset #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sets. (Fix for PhilJay#2369). Removed statements where completely not needed as calculating offsets is alredy done in BarLineCharBase#calculateOffsets(...)
|
LGTM And thank you for using the template 👍 |
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
…-legend-offset-is-not-calculated-twice-for-line-chart Remove mLabelRotatedHeight counted twice, when calculating legend offset
danielgindi
added a commit
to ChartsOrg/Charts
that referenced
this pull request
Jan 26, 2020
IncredibleStar
added a commit
to IncredibleStar/daniel-charts
that referenced
this pull request
May 26, 2021
rcblue
added a commit
to rcblue/Charts
that referenced
this pull request
Jan 6, 2023
SwiftPolar
pushed a commit
to SwiftPolar/Charts
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2369.
PR Checklist:
Modified the code as described in Issue LineChart: Axis mLabelRotatedHeight is counted twice when calculating offsets #2369 to see, that the issue still exists.
Checked against different positions of Legend (TOP, BOTTOM).
No need for that, I think.
Issue LineChart: Axis mLabelRotatedHeight is counted twice when calculating offsets #2369
PR Description
Removed statements described in ticket as they were completely not needed. Calculating offsets is already done in
BarLineCharBase#calculateOffsets(...)(calculateLegendOffsets(...)is called inside it).The code, where calculating legend offset is done in
BarChartLineBase#473Modified temporarily
LineChartActivity1code to reproduce the issue and tested against various legend positions.Additionally I changed one inner variable name to be more of Java style.