Tree-traversal iterative design & analytic-mode #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for many-shot iterative_qpe algo.
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
albi3ro
reviewed
Aug 14, 2024
mudit2812
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Looks pretty good! Just some final comments for the implementation.
The only other thing that comes to mind is testing. There's an ongoing effort right now to rework mid-circuit measurement tests, with @obliviateandsurrender and @astralcai leading the work. They might be able to provide more context, but it might be worth adding unit tests in favour of the integration tests in test_default_qubit_native_mcm.py.
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
albi3ro
reviewed
Aug 19, 2024
albi3ro
reviewed
Aug 19, 2024
albi3ro
reviewed
Aug 19, 2024
mudit2812
approved these changes
Aug 20, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
albi3ro
approved these changes
Aug 20, 2024
mudit2812
added a commit
that referenced
this pull request
Sep 10, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
The tree-traversal algorithm was first implemented using a recursive
approach for simplicity, but this potentially requires very deep stack
calls for circuits with a lot of MCMs. Tree-traversal could also support
analytic execution, optionally with a probability cutoff to ignore
branches.
**Description of the Change:**
Implement tree-traversal using an iterative approach.
Support `shots=None`.
Some profiling and optimization.
**Benefits:**
Remove system call increasing the default recursion call limit.
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-65241]
---------
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The tree-traversal algorithm was first implemented using a recursive approach for simplicity, but this potentially requires very deep stack calls for circuits with a lot of MCMs. Tree-traversal could also support analytic execution, optionally with a probability cutoff to ignore branches.
Description of the Change:
Implement tree-traversal using an iterative approach.
Support
shots=None.Some profiling and optimization.
Benefits:
Remove system call increasing the default recursion call limit.
Possible Drawbacks:
Related GitHub Issues:
[sc-65241]