Allow treating all number literals as BigDecimals to avoid NumberFormatExceptions #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need to run some benchmark with these changes. But it sounds good to me. Can you adjust the documentation too with the new option in this PR ? |
|
Sure, docs updated. Setting this option to true may indeed cause some small performance degradation (BigDecimals are slower than Longs/Doubles by nature). I'd still keep it for folks that would rather sacrifice a bit of performance but gain 100% precision when doing math. In my use case I'm using Pebble as an expression evaluation engine (to calculate Excel-like formulas using my own set of Functions and Operators) and this option is vital to me - without it I have to make workarounds by creating custom Functions to explicitly convert String-based args to BigDecimals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a literal is big enough, with current implementation there will be a NumberFormatException thrown during the processing of the Template. There should be an option to treat all number literals as BigDecimals. It will help avoiding this exception and also enforce precise arithmetics when performing calculations.