Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base rector config #962

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Add base rector config #962

merged 3 commits into from
Nov 6, 2023

Conversation

pierredup
Copy link
Member

No description provided.

@pierredup pierredup added this to the 1.7.1 milestone Nov 6, 2023
@pierredup pierredup self-assigned this Nov 6, 2023
Copy link

what-the-diff bot commented Nov 6, 2023

PR Summary

  • Updated .gitignore
    The file .gitignore has been updated to ignore certain config files typical of a developer's local environment, preventing them from being accidentally committed to the repository.
  • Added New Dependency
    A new software library, rector/rector, has been added to our project's dependencies. This tool helps us improve our code by automatically applying certain guidelines and standards.
  • Added Rector Configuration File
    A rector.php file has been added for custom configuration of the rector tool.
  • Improved Code in Various Files
    Several files, including ConvertPaymentAction.php, TableGatewayStorage.php, GetHttpRequestAction.php, ArrayObject.php, CreditCardDate.php, Identity.php, PayumBuilder.php, HumanifyTest.php, AuthorizeAction.php, GetAddresses.php and StatusAction.php have been updated for better performance and correctness. The changes primarily revolve around how certain variables and functions are checked and evaluated.
  • Refined Data Validation in Payment Conversion Actions
    Specifically in ConvertPaymentAction.php and ConvertPayoutAction.php, the verification and handling of values associated with transactions such as currency code and amount have been improved.

@pierredup pierredup force-pushed the rector-config branch 2 times, most recently from ef457da to 359fe1c Compare November 6, 2023 07:10
@pierredup pierredup merged commit 70d9c18 into Payum:1.7.x Nov 6, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant