Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fast Animations] Add support for non-integral update rates. #542

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

seraku24
Copy link
Contributor

@seraku24 seraku24 commented Apr 2, 2020

Fixes #541.

Verified the new logic works by recording gameplay and counting frames of animation of a weapon swing (from the first appearance of the sword to the character resuming a standing pose).

Rate Frame Count
1.0 24
1.5 16
2.0 12

NOTE: Your coding conventions differ from mine for C#, so I hope I have matched your style properly. Let me know if I need to correct anything.

@seraku24 seraku24 changed the title [FastAnimations] Add support for non-integral update rates. (Fixes #541) [Fast Animations] Add support for non-integral update rates. Apr 2, 2020
@Pathoschild Pathoschild self-requested a review April 3, 2020 00:17
@Pathoschild Pathoschild added this to the 2020-04 milestone Apr 3, 2020
@Pathoschild Pathoschild merged commit bad4233 into Pathoschild:develop Apr 3, 2020
@Pathoschild
Copy link
Owner

Thanks for the PR! Merged into develop for the upcoming Fast Animations 1.8.

Some animations don't use SpeedUpPlayer, but I'll fix those after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fast Animations] Support fractional playback rates
2 participants