Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content Patcher] random token problem #529

Closed
dalbiblue opened this issue Mar 13, 2020 · 14 comments
Closed

[Content Patcher] random token problem #529

dalbiblue opened this issue Mar 13, 2020 · 14 comments
Assignees
Milestone

Comments

@dalbiblue
Copy link

dalbiblue commented Mar 13, 2020

I recently created a mode to marry a wizard. It is the Romanceable Rasmodius mode I edited.
I used a random token in this mode.
However, after the token's marriage to the wizard, I found that the token was unable to kiss him and the ambassador was not printing properly. What is wrong?
This is what i wrote. ↓

{
"Action": "Load",
"Target": "Characters/Dialogue/Wizard",
"FromFile": "assets/Characters/Dialogue/wizard-{{random: 0, 1, 2, 3, 4}}.json"
},

{
"Action": "Load",
"Target": "Characters/Dialogue/MarriageDialogueWizard",
"FromFile": "assets/Characters/Dialogue/MarriageDialogueWizard.json"
},

@dalbiblue dalbiblue changed the title Random Token Problem [Romanceable Rasmodius] Random Token Problem Mar 13, 2020
@Pathoschild
Copy link
Owner

Can you do this to provide more info?

  1. Try it again.
  2. In the SMAPI console window, enter this command:
    patch summary
  3. Upload your SMAPI log to smapi.io/log (see instructions on that page).
  4. Post the link here.

@dalbiblue
Copy link
Author

https://smapi.io/log/a2d738d02fbc4c1794cde9a6947428aa
Thank you. I will send you my mod if you need.

@Pathoschild
Copy link
Owner

It looks like you didn't load the save. Can you try talking to the wizard (so you should see their dialogue), then run the command and post the log?

@dalbiblue
Copy link
Author

https://smapi.io/log/cd993ddabcfb4f609e3cf962f8d6056c

i'm sorry, my mistake!

@Pathoschild
Copy link
Owner

Both Characters/Dialogue/Wizard and Characters/Dialogue/MarriageDialogueWizard seem to be loaded and applied correctly. Neither of those patches should have any effect on whether you can kiss him, but I'm not sure what you mean by "the ambassador was not printing properly"; could you rephrase?

@dalbiblue
Copy link
Author

Even when the wizard is outside the house, he speaks indoors line. Sorry my bad English.
And, I can kiss him by subtracting the random token.

@Pathoschild
Copy link
Owner

The game only updates dialogue when the day starts, so unfortunately you can't have indoor/outdoor dialogue using only Content Patcher conditions. (It is possible with location dialogue though.)

Can you post a zip of the mod and your save folder? I'll take a look at the kissing issue.

@dalbiblue
Copy link
Author

save file.zip
romantic wizard mod.zip

Thank you! Incidentally, I can kiss sometimes. But most can't.

@dalbiblue
Copy link
Author

dalbiblue commented Mar 22, 2020

You may already know, according to the report of users who used this mode, if you can have an additional conversation at 11:00, you can kiss after 11:00 even if you did not kiss in the morning. I hope this report helps. Thank you!

@Pathoschild
Copy link
Owner

Pathoschild commented Mar 22, 2020

Sorry for the slow response! Work has been busy.

When I loaded your save, the wizard was outside and I was able to kiss him right away after talking to him. Does it work for you if you temporarily remove all mods except Content Patcher and the Romanceable Rasmodius content pack?

@dalbiblue
Copy link
Author

dalbiblue commented Mar 23, 2020

Thanks for taking a look at my mods!
As you advised, I tried removing other mods and playing romantic wizard mod. But still couldn't kiss the wizard. I was able to kiss on the first day, but I can't kiss him after the next day. Can you take a look again?
Thank you very much for taking the time out of your busy schedule.

@Pathoschild
Copy link
Owner

@dalbiblue I can't reproduce it, so we'll need to narrow it down. Does it still happen if you remove all patches except Data\NPCDispositions (so he's still marriageable), that dialogue patch, and the minimum of other patches required for the mod to work? Can you post a zip of the smaller content pack if so?

@dalbiblue
Copy link
Author

dalbiblue commented Mar 29, 2020

I narrow it down and attach it. The only remaining are Character sprite, Dialogue, MarriageDialogue, and NPCDispositions. I tried again with this miniature version but still couldn't kiss the next day.
I hope this problem solves well.
Romantic Wizard_narrow ver.zip

@Pathoschild
Copy link
Owner

Pathoschild commented Mar 31, 2020

I reproduced it with that version, but it's not related to Content Patcher.

The issue happens when the game adds a marriage dialogue key that doesn't exist in the file, like spouseRoom_Wizard. The game won't let you kiss him because he has dialogue to say, but then won't show the dialogue because the key doesn't exist.

The next Lookup Anything update lets you see which marriage dialogue key is still queued in the datamining fields; feel free to ping me on Discord if you'd like a preview build.

@Pathoschild Pathoschild self-assigned this Mar 31, 2020
@Pathoschild Pathoschild added this to the 2020-04 milestone Mar 31, 2020
@Pathoschild Pathoschild changed the title [Romanceable Rasmodius] Random Token Problem [Content Patcher] random token problem Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants