Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire entity knockback event for ownerless tnt #7171

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fire entity knockback event for ownerless tnt #7171

merged 1 commit into from
Feb 16, 2024

Conversation

Machine-Maker
Copy link
Member

Fixes #7169

@Machine-Maker Machine-Maker requested a review from a team as a code owner December 21, 2021 22:59
@vytskalt vytskalt mentioned this pull request Jan 30, 2022
Open
@stale
Copy link

stale bot commented Feb 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from 2077d2b to d452fec Compare February 20, 2022 19:08
@stale stale bot removed the resolution: stale label Feb 20, 2022
@stale
Copy link

stale bot commented Apr 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from d452fec to 0b49301 Compare April 24, 2022 04:03
@stale stale bot removed the resolution: stale label Apr 24, 2022
@Machine-Maker
Copy link
Member Author

Rebased for 1.18.2

@stale
Copy link

stale bot commented Jun 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 2, 2022

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

@stale stale bot closed this Jul 2, 2022
@Machine-Maker Machine-Maker reopened this Jul 3, 2022
@Machine-Maker Machine-Maker added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. status: rebase required and removed resolution: stale labels Jul 3, 2022
@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from 0b49301 to 7c904f8 Compare March 5, 2023 21:53
@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from 7c904f8 to 83326d9 Compare September 15, 2023 21:46
@Machine-Maker
Copy link
Member Author

Rebased for 1.20.1

@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from 83326d9 to 0f96ded Compare September 15, 2023 22:14
@YHDiamond
Copy link

Any idea when this will be merged? I'm relying on it for a project so if there is anything I could do to make it go faster please let me know.

@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from 0f96ded to b6352b8 Compare February 10, 2024 21:38
@vLuckyyy
Copy link

Any idea when this will be merged? I'm relying on it for a project so if there is anything I could do to make it go faster please let me know.

I think it would be great if we could get this merged. I have same problem with.

@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from b6352b8 to 373602d Compare February 16, 2024 23:15
@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from 373602d to ceaaa58 Compare February 16, 2024 23:35
@Machine-Maker Machine-Maker force-pushed the fix/knockback-event-for-tnt branch from ceaaa58 to aa14e29 Compare February 16, 2024 23:37
@Machine-Maker Machine-Maker merged commit 7ccefdc into PaperMC:master Feb 16, 2024
3 checks passed
@Machine-Maker Machine-Maker deleted the fix/knockback-event-for-tnt branch February 16, 2024 23:44
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
@Machine-Maker @lynxplay
Fire entity knockback event for ownerless tnt (PaperMC#7171)
2220b73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Warriorrrr Warriorrrr Warriorrrr approved these changes

@lynxplay lynxplay lynxplay approved these changes

@electronicboy electronicboy electronicboy approved these changes

Assignees
No one assigned
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EntityKnockbackByEntityEvent not called if there's no source entity
6 participants
@Machine-Maker @YHDiamond @vLuckyyy @electronicboy @lynxplay @Warriorrrr