Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build_once for cycle_gan #4108

Merged
merged 2 commits into from
Dec 25, 2019

Conversation

songyouwei
Copy link
Contributor

  • update cycle_gan to support remove build once
  • use Layer.sublayer.parameters() instead of hard-coded name filters

@songyouwei songyouwei force-pushed the update_build_once_cycle_gan branch from d5e9c63 to 74a3dec Compare December 23, 2019 10:00

self.conv0 = conv2d(self.full_name(),
self.conv0 = conv2d(
num_channels=3,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why hard code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to and input_channel arg

@@ -84,7 +84,7 @@ def train(args):
A_test_reader = data_reader.a_test_reader()
B_test_reader = data_reader.b_test_reader()

cycle_gan = Cycle_Gan("cycle_gan", istrain=True)
cycle_gan = Cycle_Gan(istrain=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "input channel" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

 for cycle_gan
test=develop
Copy link
Contributor

@tink2123 tink2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review December 25, 2019 08:45
@phlrain phlrain merged commit 7634fe7 into PaddlePaddle:develop Dec 25, 2019
@songyouwei songyouwei deleted the update_build_once_cycle_gan branch December 25, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants