-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update build_once for cycle_gan #4108
update build_once for cycle_gan #4108
Conversation
test=develop
d5e9c63
to
74a3dec
Compare
dygraph/cycle_gan/model.py
Outdated
|
||
self.conv0 = conv2d(self.full_name(), | ||
self.conv0 = conv2d( | ||
num_channels=3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why hard code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to and input_channel
arg
dygraph/cycle_gan/train.py
Outdated
@@ -84,7 +84,7 @@ def train(args): | |||
A_test_reader = data_reader.a_test_reader() | |||
B_test_reader = data_reader.b_test_reader() | |||
|
|||
cycle_gan = Cycle_Gan("cycle_gan", istrain=True) | |||
cycle_gan = Cycle_Gan(istrain=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "input channel" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
for cycle_gan test=develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Layer.sublayer.parameters()
instead of hard-coded name filters