Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify senta dygraph #4070

Merged
merged 2 commits into from
Dec 19, 2019
Merged

modify senta dygraph #4070

merged 2 commits into from
Dec 19, 2019

Conversation

JesseyXujin
Copy link
Contributor

  1. add infer benchmark
    2.modify network gru/bow
    3.add more information in README.md

@claassistantio
Copy link

claassistantio commented Dec 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

xyzhou-puck
xyzhou-puck reviewed Dec 14, 2019
View reviewed changes
Copy link
Contributor

@xyzhou-puck xyzhou-puck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double-check the implementation of CNN, I believe the shape of the CNN output may not be matched with the static graph version since there is a padding in the CNN.

@xyzhou-puck
Copy link
Contributor

I check the GRU net, it is consistent with the static graph version.

xyzhou-puck
xyzhou-puck approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@xyzhou-puck xyzhou-puck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JesseyXujin JesseyXujin merged commit 45f9a3d into PaddlePaddle:develop Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyzhou-puck xyzhou-puck xyzhou-puck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesseyXujin @claassistantio @xyzhou-puck