Polish usage of deprecated or private API in dygraph #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiqiu
force-pushed
the
dev/update_dygraph_models
branch
from
deaff62 to
f1afa8f
Compare
zhiqiu
changed the title
zhiqiu
force-pushed
the
dev/update_dygraph_models
branch
from
f1afa8f to
b0dca4a
Compare
zhiqiu
force-pushed
the
dev/update_dygraph_models
branch
from
b0dca4a to
c2311fb
Compare
|
|
phlrain
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title, this PR Polishes the usage of deprecated or private API in dygraph, i.e., APIs start with
_._ivaris removed since PR21359, we split VarBase (which is used in dygraph mode) from Variable (which is used in static mode).to_variableandlayers.xxwill return anVarBaseobject, Variable does not hold_ivarany more._stop_gradientis a private API, usestop_gradientinstead.