Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dygraph model save #3369

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Fix dygraph model save #3369

merged 2 commits into from
Sep 23, 2019

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Sep 19, 2019 •
edited
Loading

Currently, data parallel training using dygraph is a multi-process method, so if parameters need to be saved during training, the saving action should only be called in one process.

JiabinYang
JiabinYang reviewed Sep 19, 2019
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe Add more desc in PR info?

JiabinYang
JiabinYang approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit 32ae4f2 into PaddlePaddle:develop Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiabinYang JiabinYang JiabinYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chengduoZH @JiabinYang