Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppdetpose test ok #5470

Merged
merged 2 commits into from
Apr 11, 2023
Merged

ppdetpose test ok #5470

merged 2 commits into from
Apr 11, 2023

Conversation

zhiboniu
Copy link
Contributor

PR types

Performance optimization

PR changes

Models

Description

update pose model by ppdetpose in controlnet to improve performance

@paddle-bot
Copy link

paddle-bot bot commented Mar 30, 2023

Thanks for your contribution!

@guoshengCS
Copy link
Contributor

这里应该是代码风格规范有些问题,可以用下pre-commit

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #5470 (ebb6f34) into develop (7540ae9) will increase coverage by 6.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #5470      +/-   ##
===========================================
+ Coverage    52.60%   59.42%   +6.82%     
===========================================
  Files          472      482      +10     
  Lines        66941    68106    +1165     
===========================================
+ Hits         35212    40472    +5260     
+ Misses       31729    27634    -4095     

see 159 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@westfish
Copy link
Contributor

westfish commented Apr 7, 2023

测试的时候发现了这个问题:
image
貌似是初始化XarFile的时候https://github.com/PaddlePaddle/PaddleHub/blob/b402610a6f0b382a978e82473b541ea1fc6cf09a/paddlehub/utils/xarfile.py#L85 这个后面少了一个else导致的?

@zhiboniu
Copy link
Contributor Author

zhiboniu commented Apr 7, 2023

测试的时候发现了这个问题: image 貌似是初始化XarFile的时候https://github.com/PaddlePaddle/PaddleHub/blob/b402610a6f0b382a978e82473b541ea1fc6cf09a/paddlehub/utils/xarfile.py#L85 这个后面少了一个else导致的?

我这里用的时候没有遇到这个问题,是否是paddlehub版本差别呢?这个paddlehub跟之前一样的,应该使用上不会有问题。

@westfish
Copy link
Contributor

westfish commented Apr 7, 2023

测试的时候发现了这个问题: image 貌似是初始化XarFile的时候https://github.com/PaddlePaddle/PaddleHub/blob/b402610a6f0b382a978e82473b541ea1fc6cf09a/paddlehub/utils/xarfile.py#L85 这个后面少了一个else导致的?

我这里用的时候没有遇到这个问题,是否是paddlehub版本差别呢?这个paddlehub跟之前一样的,应该使用上不会有问题。

你用的什么版本的paddlehub呀

@westfish
Copy link
Contributor

westfish commented Apr 7, 2023

image
貌似没有上传这个yml文件

@zhiboniu
Copy link
Contributor Author

zhiboniu commented Apr 7, 2023

image 貌似没有上传这个yml文件

我用的paddlehub是2.3.1版本的。
这个yml文件不需要上传,是跟模型放在一起的,你可以从ppdet的repo里下载或者找我要都可以。

Copy link
Contributor

@westfish westfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return img_padded, pad


# transfer caffe model to pytorch which will match the layer name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数应该没有用到,可以删去

@westfish westfish merged commit 37e5205 into PaddlePaddle:develop Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants