Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup][B-5] clean some to_variable for test #61530

Merged
merged 1 commit into from
Feb 3, 2024
Merged

[Cleanup][B-5] clean some to_variable for test #61530

merged 1 commit into from
Feb 3, 2024

Conversation

NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Feb 3, 2024 •
edited by SigureMo
Loading

PR types

Others

PR changes

Others

Description

#61385

  • test_conv2d_transpose_layer.py : √
  • test_conv3d_transpose_layer.py : √
  • test_correlation.py : √
  • test_cross_op.py : √
  • test_cycle_gan.py : √
  • test_declarative.py : ?
  • test_detach.py : √
  • test_detection.py : √
  • test_dict.py : √
  • test_directory_migration.py : ?

test_declarative.py 中的 to_variable 都是 dyfunc_to_variable

from test_basic_api_transformation import dyfunc_to_variable

dyfunc_to_variable 在 test_basic_api_transformation.py 中（B-2）

test_directory_migration.py 好像是比较api迁移前后有没有问题，不知道需不需要改动这里的

@gouzil

@NKNaN NKNaN changed the title [Cleanup][A-1] clean some to_variable for test [Cleanup][B-5] clean some to_variable for test Feb 3, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 3, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 3, 2024
@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Feb 3, 2024
@SigureMo
Copy link
Member

SigureMo commented Feb 3, 2024

PR 模板要严格遵守，这次帮你改了

@gouzil gouzil mentioned this pull request Feb 3, 2024
Closed
SigureMo
SigureMo approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit 3ce8fc6 into PaddlePaddle:develop Feb 3, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NKNaN @SigureMo