tests: Add "C-unwind" to extern functions that can panic #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Rust 1.81 `extern "C"` functions are by-default not allowed to unwind and instead follow the `panic=abort` strategy. As a consequence, the `#[should_panic]` macro no longer works on `extern "C"` functions that panic. To mitigate one can change the signature from `extern "C"` to `extern "C-unwind"` to change the strategy. This commit does this for any unit test that uses `extern "C"` functions in combination with `#[should_panic]`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 91.11% 93.54% +2.43%
==========================================
Files 153 160 +7
Lines 44816 48221 +3405
==========================================
+ Hits 40833 45108 +4275
+ Misses 3983 3113 -870 ☔ View full report in Codecov by Sentry. |
mhasel
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Rust 1.81
extern "C"functions are by-default not allowed to unwind and instead follow thepanic=abortstrategy. As a consequence, the#[should_panic]macro no longer works onextern "C"functions that panic. To mitigate one can change the signature fromextern "C"toextern "C-unwind"to change the strategy.This commit does this for any unit test that uses
extern "C"functions in combination with#[should_panic].See also rust-lang/rust#116088