[Consensus] Remove IsSuperMajority #1418
Conversation
|
Resync completed on mainnet as well. Times seem considerably reduced. Testnet (< 2hrs) Mainnet (~4.5 hours) |
|
Code ACK 🚀 , sync time :) . |
| consensus.height_start_ZC = 863787; | ||
| consensus.height_start_StakeModifierV2 = 1967000; // Block v6: 0ef2556e40f3b9f6e02ce611b832e0bbfe7734a8ea751c7b555310ee49b61456 | ||
| consensus.height_start_TimeProtoV2 = 2153200; // Block v7: 14e477e597d24549cac5e59d97d32155e6ec2861c1003b42d0566f9bf39b65d5 | ||
| consensus.height_start_ZC = 863787; // Block v4: 5b2482eca24caf2a46bb22e0545db7b7037282733faa3a42ec20542509999a64 |
There was a problem hiding this comment.
since we're here, could we re-order the lines so that the block versions are grouped and in order (improve readability)?
also, so we need to keep height_start_MessSignaturesV2 since it has the same value as height_start_TimeProtoV2?
There was a problem hiding this comment.
Alphabetical order is used here.
Not sure that ordering by block version would make it more readable (not all height-based activations are about new block versions).
There was a problem hiding this comment.
also, so we need to keep height_start_MessSignaturesV2 since it has the same value as height_start_TimeProtoV2
If we want to unify them into a single parameter we should find a meaningful name (maybe height_start_BlocksV7 ?
There was a problem hiding this comment.
will defer and ponder this for a future PR
IsSuperMajoritychecks are slow, and not needed after enforcement.Also ISM is not a good mechanism for deployment, so will not likely be used again after BIP65.
(based on bitcoin#8391)
We should implement better fork signal/activation solutions such as BIP 9 in the future.
Note: testnet resync completed. currently checking resync on mainnet.