Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deletion example script #259

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Feature/deletion example script #259

merged 4 commits into from
Jan 31, 2020

Conversation

joshmarsh
Copy link
Contributor

@joshmarsh joshmarsh commented Jan 31, 2020

Proposed changes

Added example script for deleting dce deployed by older versions of the cli.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

marinatedpork
marinatedpork previously approved these changes Jan 31, 2020
# resource group, it deletes additional resources using substring matching on arns and resource names for the #
# namespace provided as the second parameter to the script. #
# #
# It is important to exercise caution any time you are deleting AWS resource in bulk. Please either read this script #
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pluralize resource

@joshmarsh joshmarsh merged commit ba3a7fd into Optum:master Jan 31, 2020
@joshmarsh joshmarsh deleted the feature/deletion-example-script branch January 31, 2020 23:29
@joshmarsh
Copy link
Contributor Author

#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants