fix: remove extra characters on inputs passed to deployment script in pipeline #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove double quotes and extra characters on inputs passed to
deploy.sh
script in pipeline. Currently the values being passed to this script in the pipeline are coming from terraform outputs using theterraform output
command. This can cause additional double quotes and a new line character to be added to the result (depending on the version of terraform) and can cause the script to fail. Example below:Current output being interpolated to build S3 path:
s3://"0123456789-dce-artifacts-cd"/lambda/account_pool_metrics.zip
Error:
New output (Valid S3 bucket path):
s3://0123456789-dce-artifacts-cd/lambda/account_pool_metrics.zip
Currently this error is causing the pipeline in #431 to fail. This may be due to a change made in the
terraform output
command as the PR involves upgrading from0.12.x
->1.3.x
.Types of changes
Checklist
README.md
, inline comments, etc.)CHANGELOG.md
under a## next
release, with a short summary of my changesRelevant Links
-raw
flag for terraform output - https://github.com/hashicorp/terraform/releases/tag/v0.14.3Dependent PR #431
Further comments