Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint JS files in root directory #1538

Merged
merged 1 commit into from
Nov 4, 2019
Merged

chore: lint JS files in root directory #1538

merged 1 commit into from
Nov 4, 2019

Conversation

gabegorelick
Copy link
Contributor

Not a huge deal since these files are trivial, but important if they ever grow.

@gabegorelick
chore: lint JS files in root directory
f6e1543 
Not a huge deal since these files are trivial, but important if
they ever grow.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 93.736% when pulling f6e1543 on gabegorelick:lint-root into 72e1a1b on OptimalBits:develop.

@manast
Copy link
Member

manast commented Nov 4, 2019

thanks. Not sure though what is the difference between what we have to day and this change, do you mind to clarify?

@gabegorelick
Copy link
Contributor Author

Not sure though what is the difference between what we have to day and this change, do you mind to clarify?

@manast Today, npm run lint only lints .js files in the lib and test directory. But there are a few JS files in the root directory. *.js is not recursive, so it only globs the 2 JS files in the root directory and not anything in sub-directories.

@manast
Copy link
Member

manast commented Nov 4, 2019

ah ok, got it, I was a bit blind earlier today. thanks :).

@manast manast merged commit f20e2f9 into OptimalBits:develop Nov 4, 2019
@gabegorelick gabegorelick deleted the lint-root branch November 5, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabegorelick @coveralls @manast