Emulate job.progress function for sandboxed processors #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job!. @stansv this PR would be great on BullMQ too :). |
|
@manast I'll port this tomorrow |
|
Happy to help! Thanks for the wonderful project and for accepting my PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Job.progress function acts as a getter and setter depending on the argument value passed to it.
In the context of a sandboxed job processor (forked process), the job instance given to the processor is actually a wrapped JSON message. The
progressfunction on the wrapped job object only behaves as an asynchronous setter.This pull request modifies the
progressfunction on the wrapped job object to behave as both a getter and a setter.