fix: unlock job when moving it to delayed #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
changed the title
papandreou
force-pushed
the
fix/releaseLockAfterRemovingToDelayed
branch
from
2c18848 to
44b9651
Compare
|
WDYT @manast? 🤗 |
|
Sorry for the late reply. Yes, you are right, this was working mostly out of luck, thanks for the fix. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 21, 2022
## [4.8.2](v4.8.1...v4.8.2) (2022-04-21) ### Bug Fixes * unlock job when moving it to delayed ([#2329](#2329)) ([11eae6b](11eae6b))
|
🎉 This PR is included in version 4.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! For various reasons I'm using a rather high
lockDurationsetting in my app, and I noticed that jobs that fail an attempt and have to be moved todelayedremain locked. This means that I cannot easily remove such a job from our small homegrown queue control app, as it isn't the lock-taker.When I tried to figure out what was going on, I noticed this comment:
bull/lib/job.js
Line 309 in 61a87a8
... However, it seems like the job isn't actually being unlocked by
moveToDelayed-3, so I tried fixing that 😇