PSF time now double (was float). Both write (Actor) and read (Source) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is fine. I remember we had some discussion about this about half a year ago. But I cannot find it, neither in the mail archive nor in the GitHub issues. It would be good to send a message to the user who originally raised this issue, that we think it's now solved. In order not to forget about this, I am waiting with merging and closing this request until we find that original discussion back... :) |
dsarrut
added a commit
that referenced
this pull request
Nov 7, 2019
PSF time now double (was float). Both write (Actor) and read (Source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GatePhaseSpaceActor used to compute & write the particle time in float. Sometimes not enough, changed to double.
GateSourcePhaseSpace detect if stored time is float or double.