C++: Fix incorrect handling of blank lines in doc comments; fix a minor mistake introduced in the prior PR #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request
/Response
aliases out of the_traits_
; this was changed by mistake in C++: Avoid name collisions and add missing const begin()/end() methods to VLA #287I find the naming of the service pseudo-type
Service_{{major}}_{{minor}}
non-obvious and I would like to suggest renaming it such that the service pseudo-type is named after the service itself suffixed with the version numbers. This would be in line with the way it is implemented in Python. Instead of this:We would have this:
Then there already are aliases inside
Access_1_0
which means that the full set of the available names is as follows:See related discussion in #155 and #190