Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bool specialization for VariableLengthArray; fix AUTOSAR compliance issues; fix GTest integration #284

Merged
merged 26 commits into from
Mar 3, 2023
Merged

Add bool specialization for VariableLengthArray; fix AUTOSAR compliance issues; fix GTest integration #284

merged 26 commits into from
Mar 3, 2023

Conversation

pavel-kirienko
Copy link
Member

@pavel-kirienko pavel-kirienko commented Mar 2, 2023 •
edited
Loading

There is a fair amount of code duplication between the generic and specialized versions of VariableLengthArray. It is possible to eliminate some of it by extracting commonalities into a base class.

@pavel-kirienko pavel-kirienko self-assigned this Mar 2, 2023
@pavel-kirienko pavel-kirienko added feature New feature or request major A major issue that should be a priority labels Mar 2, 2023
@pavel-kirienko
Run black
09c1abf
@pavel-kirienko
Disable -Wzero-as-null-pointer-constant in C++ test that depends on C…
57a16ef 
… headers; however, the proper solution here is to move C headers into a separate directory and make it SYSTEM
@pavel-kirienko pavel-kirienko marked this pull request as ready for review March 2, 2023 20:32
@pavel-kirienko pavel-kirienko requested review from thirtytwobits and asmfreak and removed request for thirtytwobits March 2, 2023 20:32
thirtytwobits
thirtytwobits approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@thirtytwobits thirtytwobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of work. Thanks for contributing to Nunavut!

src/nunavut/lang/cpp/support/variable_length_array.hpp Outdated Show resolved Hide resolved
@pavel-kirienko pavel-kirienko mentioned this pull request Mar 3, 2023
Open
@pavel-kirienko pavel-kirienko enabled auto-merge (squash) March 3, 2023 13:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@pavel-kirienko pavel-kirienko merged commit b903b8e into main Mar 3, 2023
@pavel-kirienko pavel-kirienko deleted the cpp branch March 3, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirtytwobits thirtytwobits thirtytwobits approved these changes

@asmfreak asmfreak Awaiting requested review from asmfreak

Assignees

@pavel-kirienko pavel-kirienko

Labels
feature New feature or request major A major issue that should be a priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++: Missing bool specialization for the variable-length array Missing includes in c++ serialization.hpp
2 participants
@pavel-kirienko @thirtytwobits