New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #273

Merged

thirtytwobits merged 7 commits into main from v2

Jan 27, 2023

Member

thirtytwobits commented Jan 25, 2023

Merging v2 into main for release

thirtytwobits and others added 7 commits

November 4, 2022 13:00


          First iteration on v2 (#265)

Nunavut V2 is not a huge change from v1 but it the Python APIs are
different enough to warrent the semantic, major revision bump.

The core difference is a refactor of the Language objects to fully
support the properties.yaml schema and allow overrides to be provided to
nnvg.

A follow-up to this change, before v2 is published, will be a refactor
of the internal package and module names to improve encapsulation and to
be more consistent with the style of other OpenCyphal python projects.

Co-authored-by: Kening Hu <kening@amazon.com>


          refactoring Python API (#266)

41a1512

* refactoring Python API

* shoring up coverage


          fixing CI

ac707fa


          Cyphalization and rolling back c++11 stuff

fcfd8e9


          whoops

3c3e559


          Add fix for primitive memebers initialization and C++ constants strop…

718cb4d

…ping (#270)


          Updating CI workflow

4d19203

Updating actions and fixing older python versions to the platforms that had support for them.

thirtytwobits force-pushed the v2 branch from e9029e0 to 4d19203 Compare

January 27, 2023 19:06

sonarqubecloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

95.8% Coverage
0.0% Duplication

thirtytwobits requested a review from pavel-kirienko

January 27, 2023 19:32

Member Author

thirtytwobits commented Jan 27, 2023

Looks like we're green on the CI finally. Just need a review of the merge.

pavel-kirienko reviewed

View reviewed changes

Member

pavel-kirienko left a comment

I did not actually review the code as the diff is large, but I understood this is not required in this case, as we all agree on where this is going.

pavel-kirienko approved these changes

View reviewed changes

thirtytwobits merged commit 8fff5a0 into main

thirtytwobits deleted the v2 branch

January 27, 2023 20:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet