Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #254 with tests #256

Merged
merged 2 commits into from
May 20, 2022
Merged

Fixing #254 with tests #256

merged 2 commits into from
May 20, 2022

Conversation

thirtytwobits
Copy link
Member

  1. Adding explicit little-endian tests to CI
  2. Fixing issues found by said tests.
  3. Small documentation fixes and update to public_regulated_data_types
    submodule.

@thirtytwobits
Fixing OpenCyphal#254 with tests
f8fbf50 
1. Adding explicit little-endian tests to CI
2. Fixing issues found by said tests.
3. Small documentation fixes and update to public_regulated_data_types
   submodule.
@thirtytwobits
Copy link
Member Author

Seems the tests show there's more work todo...

@thirtytwobits thirtytwobits marked this pull request as draft May 20, 2022 19:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thirtytwobits thirtytwobits marked this pull request as ready for review May 20, 2022 20:22
@thirtytwobits thirtytwobits merged commit 142d6d5 into OpenCyphal:main May 20, 2022
@asmfreak asmfreak mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-kirienko pavel-kirienko pavel-kirienko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thirtytwobits @pavel-kirienko