Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Fixed length boolean arrays should be represented as std::bitset #283

Closed
pavel-kirienko opened this issue Mar 2, 2023 · 2 comments
Closed

C++: Fixed length boolean arrays should be represented as std::bitset #283

pavel-kirienko opened this issue Mar 2, 2023 · 2 comments

Comments

@pavel-kirienko
Copy link
Member

pavel-kirienko commented Mar 2, 2023 •
edited
Loading

cc @thirtytwobits @asmfreak

This is critical because without this optimization, uavcan.port.List cannot be used in small embedded systems. See https://nunaweb.opencyphal.org/api/storage/docs/docs/uavcan/index.html#uavcan_node_port_SubjectIDList_0_1
@pavel-kirienko
Copy link
Member Author

Looking at the current implementation, I assume this will require an extension of the configuration parameter set unless we want to hard-code std::bitset for booleans.

thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 2, 2023
@thirtytwobits
python changes for OpenCyphal#283
0073ba4
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 3, 2023
@thirtytwobits
python changes for OpenCyphal#283
bba27c3
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 3, 2023
@thirtytwobits
fix for OpenCyphal#283
fe0a29f
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 3, 2023
@thirtytwobits
fix for OpenCyphal#283
e2e2a01
@thirtytwobits thirtytwobits mentioned this issue Mar 3, 2023
Merged
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 6, 2023
@thirtytwobits
python changes for OpenCyphal#283
72a8734
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 6, 2023
@thirtytwobits
fix for OpenCyphal#283
85c8221
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 7, 2023
@thirtytwobits
python changes for OpenCyphal#283
9f74a79
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Mar 7, 2023
@thirtytwobits
fix for OpenCyphal#283
1841993
thirtytwobits added a commit that referenced this issue Mar 7, 2023
@thirtytwobits
Fixes for #288, #283, and #271 (#289)
a2b24f0 
- #288 : Updating dev container documentation to point to ghcr.
- #283 : Detecting fixed boolean arrays and modifying c++ to emit
std::bitset
- #271 : Changing the type used when comparing array lengths to avoid
compiler warnings.
@thirtytwobits
Copy link
Member

This should be fixed with 2.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavel-kirienko @thirtytwobits