Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.4 comptible, php-symfony resources #20162

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

dmnlk
Copy link
Contributor

@dmnlk dmnlk commented Nov 22, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

add PHP 8.4 support

https://www.php.net/releases/8.4/en.php

In PHP 8.4, when using default arguments set to null, you are required to specify a type hint that includes either nullable or a union type with null. If this is not specified, a deprecated error will be displayed starting in PHP 8.4. This change is being addressed.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Additionally, matrix build settings have been added to ensure the project is built across multiple PHP versions.

@dmnlk
Copy link
Contributor Author

dmnlk commented Nov 22, 2024

@wing328
Copy link
Member

wing328 commented Nov 22, 2024

thanks for the PR

can you please follow step 3 to update the samples?

@dmnlk
Copy link
Contributor Author

dmnlk commented Nov 22, 2024

@wing328 run script, but nothing chages

@dmnlk
Copy link
Contributor Author

dmnlk commented Nov 22, 2024

@wing328
sorry update commit
700f234

@dmnlk
Copy link
Contributor Author

dmnlk commented Nov 22, 2024

after approval, I will check this jobs
https://github.com/OpenAPITools/openapi-generator/actions/runs/11975153606

@dmnlk dmnlk force-pushed the feature/php84-symfony branch from 1a34f46 to fbf73b1 Compare November 23, 2024 11:38
@wing328
Copy link
Member

wing328 commented Nov 23, 2024

can you please review the CI errors when you've time?

@dmnlk
Copy link
Contributor Author

dmnlk commented Nov 24, 2024

@wing328 CI all check passed

@wing328 wing328 merged commit c831983 into OpenAPITools:master Nov 24, 2024
22 checks passed
@wing328
Copy link
Member

wing328 commented Nov 24, 2024

@dmnlk just merged. thanks for the contribution.

have a nice weekend

@dmnlk dmnlk deleted the feature/php84-symfony branch November 24, 2024 08:01
php:
- "8.1"
- "8.2"
- "8.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the workflow.

shall we test with 8.4 as well? or there're pending issues that need to be resolved before the output works with 8.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 sorry i will fix soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmnlk dmnlk mentioned this pull request Nov 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants