-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.4 comptible, php-symfony resources #20162
Conversation
thanks for the PR can you please follow step 3 to update the samples? |
@wing328 run script, but nothing chages |
after approval, I will check this jobs |
1a34f46
to
fbf73b1
Compare
can you please review the CI errors when you've time? |
@wing328 CI all check passed |
@dmnlk just merged. thanks for the contribution. have a nice weekend |
php: | ||
- "8.1" | ||
- "8.2" | ||
- "8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the workflow.
shall we test with 8.4 as well? or there're pending issues that need to be resolved before the output works with 8.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 sorry i will fix soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)add PHP 8.4 support
https://www.php.net/releases/8.4/en.php
In PHP 8.4, when using default arguments set to null, you are required to specify a type hint that includes either nullable or a union type with null. If this is not specified, a deprecated error will be displayed starting in PHP 8.4. This change is being addressed.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Additionally, matrix build settings have been added to ensure the project is built across multiple PHP versions.