Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust-Axum] Dynamically set the types of integer literals #20133

Conversation

Victoria-Casasampere-BeeTheData
Copy link
Contributor

Changes the literals generated in the validators to literals that will fit the adequate types, this is necessary as literals default to i32 and values that don't fit it need its type to be specified explicitly.

This is partially related to #19291, but it does not fully fix it.

# Command used to update the samples
mvn clean &&
./bin/generate-samples.sh bin/configs/manual/rust-axum-* &&
mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request, and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Victoria-Casasampere-BeeTheData
Copy link
Contributor Author

Unsure if this is a breaking change. The default floating point literal is f64, and this makes some of the existing floating point literals become f32, which can change the accuracy of some mathematical operations, but unsure if PartialOrd is one of them

@wing328
Copy link
Member

wing328 commented Nov 19, 2024

thanks for the PR

cc @linxGnu

@wing328
Copy link
Member

wing328 commented Nov 25, 2024

if no further feedback, i'll merge this PR later this week

@linxGnu
Copy link
Contributor

linxGnu commented Nov 25, 2024

Thank you @wing328

The PR is LGTM. Please go ahead!

@wing328 wing328 merged commit a7cacce into OpenAPITools:master Nov 25, 2024
20 checks passed
@Victoria-Casasampere-BeeTheData Victoria-Casasampere-BeeTheData deleted the rust-axum-large-literals branch November 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants