Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zapier] add response middleware #19760

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[zapier] add response middleware #19760

merged 2 commits into from
Oct 2, 2024

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Oct 2, 2024 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@a-wallen a-wallen mentioned this pull request Oct 2, 2024
Closed
5 tasks
@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 2, 2024

fixes #19300

@a-wallen
Copy link
Contributor Author

a-wallen commented Oct 2, 2024

looks like @emajo gave an LGTM in #19733 with a 👍

@wing328
Copy link
Member

wing328 commented Oct 2, 2024

please update the samples when you've time and then i will merge:

diff --git a/samples/client/petstore/zapier/utils/utils.js b/samples/client/petstore/zapier/utils/utils.js
index 59403c7c..7de48fd2 100644
--- a/samples/client/petstore/zapier/utils/utils.js
+++ b/samples/client/petstore/zapier/utils/utils.js
@@ -46,15 +46,6 @@ const responseOptionsMiddleware = (z, bundle, key, json) => {
   return json
 }
 
-const isTrigger = (key) => {
-    // TODO: custom logic
-    return false
-}
-
-const triggerMiddleware = (action) => {
-    return action
-}
-
 module.exports = {
     replacePathParameters: replacePathParameters,
     childMapping: childMapping,
@@ -67,5 +58,4 @@ module.exports = {
     isTrigger: isTrigger,
     triggerMiddleware: triggerMiddleware,
     isCreateAction: isCreateAction,
-    responseOptionsMiddleware: responseOptionsMiddleware,
 }
Perform git status
HEAD detached at pull/19760/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   samples/client/petstore/zapier/utils/utils.js

@wing328 wing328 added this to the 7.9.0 milestone Oct 2, 2024
@a-wallen a-wallen force-pushed the zapier_response branch 2 times, most recently from df3955f to ec4051e Compare October 2, 2024 16:33
@wing328 wing328 merged commit 43ce2a8 into OpenAPITools:master Oct 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Zapier Enhancement: Feature
Projects
None yet
Milestone
7.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@a-wallen @wing328