Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decompilation authorization check #4821

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fix decompilation authorization check #4821

merged 1 commit into from
Oct 13, 2021

Conversation

JoeRobich
Copy link
Member

Resolves #4817

The authorization check result wasn't passed into OmniSharp activation. Instead it requested the authorization again but from the workspace state.

filipw
filipw approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@JoeRobich JoeRobich merged commit 32781a1 into dotnet:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The omnisharp.enableDecompilationSupport setting doesn't enable decompilation
2 participants
@JoeRobich @filipw